Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blocks): Mark previously-@private methods @internal #7194

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix(blocks): Mark previously-@private methods @internal #7194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions blocks/logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,8 @@ const CONTROLS_IF_MUTATOR_MIXIN = {
},
/**
* Modify this block to have the correct number of inputs.
*
* @internal
*/
updateShape_: function (this: IfBlock) {
// Delete everything.
Expand Down
4 changes: 4 additions & 0 deletions blocks/text.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ const GET_SUBSTRING_BLOCK = {
* Create or delete an input for a numeric index.
* This block has two such inputs, independent of each other.
*
* @internal
* @param n Which input to modify (either 1 or 2).
* @param isAt True if the input includes a value connection, false otherwise.
*/
Expand Down Expand Up @@ -445,6 +446,7 @@ const PROMPT_COMMON = {
/**
* Modify this block to have the correct output type.
*
* @internal
* @param newOp The new output type. Should be either 'TEXT' or 'NUMBER'.
*/
updateType_: function (this: PromptCommonBlock, newOp: string) {
Expand Down Expand Up @@ -857,6 +859,7 @@ const JOIN_MUTATOR_MIXIN = {
},
/**
* Modify this block to have the correct number of inputs.
*
*/
updateShape_: function (this: JoinMutatorBlock) {
if (this.itemCount_ && this.getInput('EMPTY')) {
Expand Down Expand Up @@ -955,6 +958,7 @@ const CHARAT_MUTATOR_MIXIN = {
/**
* Create or delete an input for the numeric index.
*
* @internal
* @param isAt True if the input should exist.
*/
updateAt_: function (this: CharAtBlock, isAt: boolean) {
Expand Down