fix(blocks): Mark previously-@private
methods @internal
#7194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Proposed Changes
Where certain block mixin methods had been marked
@private
, and these annotations had been deleted while migrating the containing files to TypeScript, mark those methods as@internal
.Behaviour Before Change
These methods might have appeared in our
.d.ts
files and external documentation.Behaviour After Change
These methods should not appear in our
d.ts
files or external documentation.Reason for Changes
The migration PRs were not intended to change any API.
Test Coverage
Passes
npm test
. No changes to manual testing required.Documentation
…may be sparser than before, intentionally.
Additional Information
I'm not actually sure if these methods appear in our external documentation at the moment—I'd guess not. But better to keep it that way.