Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Remove unneccessary visionOS #if logic #197

Merged
merged 4 commits into from
Jun 28, 2024
Merged

[NFC] Remove unneccessary visionOS #if logic #197

merged 4 commits into from
Jun 28, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 28, 2024

  1. Remove defined(TARGET_OS_VISION)
  2. TARGET_OS_IOS && !TARGET_OS_VISION can be simplified to TARGET_OS_IOS

andrewheard
andrewheard approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning these up!

@google-oss-bot
Copy link

google-oss-bot commented Jun 28, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • GoogleUtilities-ios-unit-GoogleUtilities.framework

    Overall coverage changed from 0.62% (cb3d41f) to 0.14% (71cbc4c) by -0.49%.

    FilenameBase (cb3d41f)Merge (71cbc4c)Diff
    GULAppEnvironmentUtil.m3.23%3.42%+0.20%
    GULNetworkInfo.m23.86%0.00%-23.86%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Mh0E4XCA4R.html

@ncooke3 ncooke3 merged commit 83fa5a9 into release-8.0 Jun 28, 2024
29 of 30 checks passed
@ncooke3 ncooke3 deleted the nc/vision-check branch June 28, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @google-oss-bot @paulb777 @andrewheard