Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messaging] Update TARGET_OS_* conditionals #13184

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Conversation

andrewheard
Copy link
Contributor

Updated TARGET_OS_* in Messaging now that Xcode 15.2 is required and TARGET_OS_IOS is no longer 1 on visionOS.

#no-changelog

@google-oss-bot
Copy link

google-oss-bot commented Jun 25, 2024

Coverage Report 1

Affected Products

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 57.71% (f24850f) to 58.03% (b7a8492) by +0.32%.

    FilenameBase (f24850f)Merge (b7a8492)Diff
    FIRMessagingCheckinPreferences.m93.07%98.02%+4.95%
    FIRMessagingExtensionHelper.m72.29%78.79%+6.49%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nwZqR1bdLu.html

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewheard andrewheard marked this pull request as ready for review June 25, 2024 22:46
@andrewheard andrewheard merged commit 09920d1 into main Jun 25, 2024
74 checks passed
@andrewheard andrewheard deleted the ah/messaging-target-os branch June 25, 2024 23:26
@andrewheard andrewheard linked an issue Jun 26, 2024 that may be closed by this pull request
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Jul 9, 2024
….29.0" (#1153)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://togithub.com/firebase/firebase-ios-sdk)
| minor | `from: "10.28.1"` -> `from: "10.29.0"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.29.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.29.0):
Firebase Apple 10.29.0

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.28.1...10.29.0)

The Firebase Apple SDK (10.29.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.29.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- \[Messaging] Rename initWithFileName internal method by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/13139](https://togithub.com/firebase/firebase-ios-sdk/pull/13139)
- Revert "Add SIGTERM support
([#&#8203;12881](https://togithub.com/firebase/firebase-ios-sdk/issues/12881))"
by [@&#8203;themiswang](https://togithub.com/themiswang) in
[https://github.com/firebase/firebase-ios-sdk/pull/13162](https://togithub.com/firebase/firebase-ios-sdk/pull/13162)
- \[MLModelDownloader] Use `FirebaseLogger` instead of
`GULLoggerWrapper` by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13160](https://togithub.com/firebase/firebase-ios-sdk/pull/13160)
- \[Messaging] Fix APS Environment entitlement key on visionOS by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13176](https://togithub.com/firebase/firebase-ios-sdk/pull/13176)
- \[Messaging] Update `TARGET_OS_*` conditionals by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13184](https://togithub.com/firebase/firebase-ios-sdk/pull/13184)
- VertexAI: use shared repository for test golden files by
[@&#8203;tanzimfh](https://togithub.com/tanzimfh) in
[https://github.com/firebase/firebase-ios-sdk/pull/13186](https://togithub.com/firebase/firebase-ios-sdk/pull/13186)
- Update FPRDataUtils.m by
[@&#8203;Kyle-Ye](https://togithub.com/Kyle-Ye) in
[https://github.com/firebase/firebase-ios-sdk/pull/13200](https://togithub.com/firebase/firebase-ios-sdk/pull/13200)
- \[Vertex AI] Add support for compiling on watchOS by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13215](https://togithub.com/firebase/firebase-ios-sdk/pull/13215)

#### New Contributors

- [@&#8203;tanzimfh](https://togithub.com/tanzimfh) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/13152](https://togithub.com/firebase/firebase-ios-sdk/pull/13152)
- [@&#8203;totoro642](https://togithub.com/totoro642) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/13179](https://togithub.com/firebase/firebase-ios-sdk/pull/13179)
- [@&#8203;Kyle-Ye](https://togithub.com/Kyle-Ye) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/13200](https://togithub.com/firebase/firebase-ios-sdk/pull/13200)

**Full Changelog**:
firebase/firebase-ios-sdk@10.28.1...10.29.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase Cloud Messaging not working with visionOS
4 participants