Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(generative-ai-dart) & fix(firebase_vertexai): null role on ChatSession history #198

Closed
wants to merge 2 commits into from
Closed

fix(generative-ai-dart) & fix(firebase_vertexai): null role on ChatSession history #198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a594c67
fix(generative-ai-dart) & fix(firebase_vertexai): empty content with …
Flucadetena Jul 26, 2024
8266b6e
reversed wrong formatting
Flucadetena Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkgs/google_generative_ai/lib/src/chat.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ final class ChatSession {
try {
final response = await _generateContent(_history.followedBy([message]),
safetySettings: _safetySettings, generationConfig: _generationConfig);
if (response.candidates case [final candidate, ...]) {

if (response.candidates case [final candidate, ...] when candidate.content.role != null) {
_history.add(message);
// TODO: Append role?
_history.add(candidate.content);
Expand Down