fix(generative-ai-dart) & fix(firebase_vertexai): null role on ChatSession history #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and closes issue #197
I extended the existing condition to take into account blocked Content with
null
role and avoid adding it to the history.There is a preexisting "TODO" asking if the role should be appended before adding the content to the history. I did not changed or remove the comment, although in my tests a could not reproduce a case where the role was not
user
ormodel
unless the responses had been blocked for Safety or other reasons.When blocked the
text
part is empty and would not make sense to add it to the history. So no sure the appending the role is needed.With the check the model keeps working fine and the developer can handle the Exception as it pleases, either retrying the generation or adding a default answer by the
model
so the user can rephrase and retry.Happy to give more information or make any changes. Hope it helps, thanks for the great work.