ec2_vol: preset the name tag of the volume

Depends-On: ansible-collections#241

Closes: ansible-collections#229

changelogs/fragments/242_ec2_vol-preset-the-name-tag-of-the-volume.yaml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+- ec2_vol - create or update now preserves the existing tags, including Name (https://github.com/ansible-collections/amazon.aws/issues/229) 

plugins/modules/ec2_vol.py

@@ -707,8 +707,9 @@ def main():
 
         attach_state_changed = False
         volume, changed = create_volume(module, ec2_conn, zone=zone)
-        tags['Name'] = name
-        final_tags, tags_changed = ensure_tags(module, ec2_conn, volume['volume_id'], 'volume', tags, False)
+        if name:
+            tags['Name'] = name
+        final_tags, tags_changed = ensure_tags(module, ec2_conn, volume['volume_id'], 'volume', tags, True)
 
         if detach_vol_flag:
             volume, changed = detach_volume(module, ec2_conn, volume_dict=volume)

tests/integration/targets/ec2_vol/tasks/main.yml

@@ -78,6 +78,7 @@
           - not volume1.volume.attachment_set.instance_id
           - not volume1.volume.encrypted
           - volume1.volume.tags.ResourcePrefix == "{{ resource_prefix }}"
+          - not ("Name" in volume1.volume.tags)
 
     # no idempotency check needed here
 
@@ -107,6 +108,7 @@
           - volume2.volume.size == 4
           - volume2.volume.encrypted
           - volume2.volume.tags.ResourcePrefix == "{{ resource_prefix }}"
+          - volume2.volume.tags.Name == "{{ resource_prefix }}"
 
     - name: create another volume (override module defaults) (idempotent)
       ec2_vol: