ec2_vol: returns an up to date tag dict of the volume #241
Conversation
goneri
force-pushed
the
ec2_vol-returns-an-up-to-date-tag-dict-of-the-volume_10591
branch
from
14741d2 to
30d8e6b
Compare
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
has_issue
integration
changelogs/fragments/241_ec2_vol-returns-an-up-to-date-tag-dict-of-the-volume.yaml
Outdated
Show resolved
Hide resolved
| @@ -77,6 +77,7 @@ | |||
| - "'instance_id' in volume1.volume.attachment_set" | |||
| - not volume1.volume.attachment_set.instance_id | |||
| - not volume1.volume.encrypted | |||
| - volume1.volume.tags.ResourcePrefix == "{{ resource_prefix }}" | |||
There was a problem hiding this comment.
It's very easy to mangle the tags (see also #224 (review)) I'd like to see some slightly more comprehensive tests in here.
There was a problem hiding this comment.
Hi @tremble. Can you please elaborate on what you want?
There was a problem hiding this comment.
I'm good with the tag tests being added in either this PR or the next, I'd just like to ensure that they're added especially given we're messing with tagging. If you try to add them and the results get mangled I'm also good with that just being documented and them actually being added in another PR.
tags:
"lowercase spaced": 'hello cruel world'
"Title Case": 'Hello Cruel World'
CamelCase: 'SimpleCamelCase'
snake_case: 'simple_snake_case'
This patch ensures a `ec2_vol` calls will return the up to date tag structure. Previously, the module was returning the origin tag dictionary.
goneri
force-pushed
the
ec2_vol-returns-an-up-to-date-tag-dict-of-the-volume_10591
branch
from
30d8e6b to
fba1477
Compare
ansibullbot
removed
the
needs_rebase
|
As long as we add more tag tests in 242 and other reviewer's are OK this change lgtm |
This patch ensures a
ec2_volcalls will return the up to datetag structure.
Previously, the module was returning the origin tag dictionary.