Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blue/minimal http proxy #656
Blue/minimal http proxy #656
Changes from all commits
0d28a4f
6a2c045
8e0f7bf
c9f7aea
48837c8
7f43726
d67c6f8
8b2ee45
beab4c4
8e97b6c
d01596f
f3c21e2
d4a4ebe
2025d0f
7cd7517
013bdb3
8ba2b10
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we capture
CancelledError
here?I'm not saying it's wrong, I just don't understand, and this is an example - so things should be understandable : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's because the KeyboardInterrupt can happen in some other part of async code and thus, the KeyboardInterrupt won't happen in the
asyncio.sleep(10)
but in some other place and that routine will have been cancelledThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadeofblue
OK, that makes sense.
We have a comment "wait until Ctrl+C". I think it would be nice to add the same explanation to the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.... that's also present in all the other examples, I'm unsure if we want to pollute this one with this particular explanation