Blue/minimal http proxy #656
Conversation
+ differentiate response to show which node executed the request
| print(instances()) | ||
| try: | ||
| await asyncio.sleep(10) | ||
| except (KeyboardInterrupt, asyncio.CancelledError): |
There was a problem hiding this comment.
Why do we capture CancelledError here?
I'm not saying it's wrong, I just don't understand, and this is an example - so things should be understandable : )
There was a problem hiding this comment.
I believe it's because the KeyboardInterrupt can happen in some other part of async code and thus, the KeyboardInterrupt won't happen in the asyncio.sleep(10) but in some other place and that routine will have been cancelled
There was a problem hiding this comment.
@shadeofblue
OK, that makes sense.
We have a comment "wait until Ctrl+C". I think it would be nice to add the same explanation to the comment.
There was a problem hiding this comment.
hmm.... that's also present in all the other examples, I'm unsure if we want to pollute this one with this particular explanation
add comment to `run_local_server`
Co-authored-by: johny-b <[email protected]>
closes #652