enable parametrization of Service instances within a single Golem.run_service() call
#514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_service()` call + use of service parametrization in `simple-service-poc`
shadeofblue
changed the title
Golem.run_service() callGolem.run_service() call
azawlocki
reviewed
Jul 5, 2021
yapapi/golem.py
Outdated
Comment on lines
134
to
144
| :param num_instances: optional number of service instances to run. Defaults to a single | ||
| instance, unless `instance_params` is given, in which case, the Cluster will be created | ||
| with as many instances as there are elements in the `instance_params` iterable. | ||
| :param instance_params: optional list of dictionaries of keyword arguments that will be passed | ||
| to consecutive, spawned instances. The number of elements in the iterable determines the | ||
| number of instances spawned, unless `num_instances` is given, in which case the latter takes | ||
| precedence. | ||
| In other words, if both `num_instances` and `instance_params` are provided, | ||
| the Cluster will be created with the number of instances determined by `num_instances` | ||
| and if there are too few elements in the `instance_params` iterable, it will results in | ||
| an error. |
azawlocki
approved these changes
Jul 5, 2021
There was a problem hiding this comment.
Nice! My only concern is that is conflicts with changes made in b0.6 with #509 (for example, both PR's modify signature of Cluster._run_instance()), perhaps it would be better to merge b0.6 with master before merging this PR?
azawlocki
reviewed
Jul 5, 2021
we can do either, and i'd merge this one first for the sake of planning ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable parametrization of Service instances within a single
Golem.run_service()callsimple-service-poccloses #372