Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow parametrization of Service instances #372

Closed
shadeofblue opened this issue May 13, 2021 · 2 comments · Fixed by #514
Closed

allow parametrization of Service instances #372

shadeofblue opened this issue May 13, 2021 · 2 comments · Fixed by #514

Comments

@shadeofblue
Copy link
Contributor

shadeofblue commented May 13, 2021

(within a single Cluster)

[ with regards to Payload parameters, we probably won't want to have a single cluster with services that commission different payloads since then it needs to request separate Demands et al anyway ]

@stranger80
Copy link

Maybe we should leverage a concept similar to batch task input data? ie. instead of:

cluster = golem.run_service(
            TurbogethService,
            # payload=payload,
            num_instances=INSTANCES_NEEDED,
        )

have:

cluster = golem.run_service(
            TurbogethService,
            # payload=payload,
            instance_parameters # collection of instance parameter objects 
        )

...where instance_parameters is a collection of parameter objects, each of which would be passed into TurbogethService, either as a param to start() (so that it can be stored in the class field), or via some dedicated init(instance_parameter) method...?

@shadeofblue
Copy link
Contributor Author

@stranger80 good idea, though, I wouldn't remove num_instances since it by far a clearer way to specifiy multiple copies if one doesn't need to differentiate them

@shadeofblue shadeofblue added the enhancement New feature or request label May 28, 2021
@shadeofblue shadeofblue changed the title [enhancement] allow parametrization of Service instances allow parametrization of Service instances Jun 11, 2021
@shadeofblue shadeofblue self-assigned this Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants