Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the default Service.run() await indefinitely instead of yielding None in a loop #448

Merged
merged 4 commits into from
Jun 9, 2021
Merged

make the default Service.run() await indefinitely instead of yielding None in a loop #448

merged 4 commits into from
Jun 9, 2021

Conversation

shadeofblue
Copy link
Contributor

No description provided.

@shadeofblue shadeofblue requested a review from a team June 9, 2021 16:56
@shadeofblue shadeofblue requested a review from azawlocki June 9, 2021 17:48
@shadeofblue
Copy link
Contributor Author

closes #443

@shadeofblue shadeofblue self-assigned this Jun 9, 2021
@shadeofblue shadeofblue changed the base branch from master to b0.6 June 9, 2021 17:52
azawlocki
azawlocki approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shadeofblue shadeofblue merged commit 017ba49 into b0.6 Jun 9, 2021
@shadeofblue shadeofblue deleted the 0.6-run-await-indefinitely branch June 9, 2021 20:48
@shadeofblue shadeofblue mentioned this pull request Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azawlocki azawlocki azawlocki approved these changes

Assignees

@shadeofblue shadeofblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadeofblue @azawlocki