Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified service.run() #433

Closed
johny-b opened this issue Jun 7, 2021 · 1 comment
Closed

Simplified service.run() #433

johny-b opened this issue Jun 7, 2021 · 1 comment
Labels
apps-dispatch

Comments

@johny-b
Copy link
Contributor

johny-b commented Jun 7, 2021

I think this default Service.run():

async def run(self):
    await asyncio.Future()
    yield

(maybe with a comment why there is yield?) would be more intelligible for the users - they will not think that any yield is really required.
@shadeofblue
Copy link
Contributor

duplicate of #443 closed via #448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
apps-dispatch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shadeofblue @johny-b