Blue/executor split #365
Blue/executor split #365
Conversation
…into blue/executor-split
…into blue/executor-split
…into blue/executor-split
rename the example based on the new API to `blender.py`
…into blue/executor-split
…into blue/executor-split
azawlocki
force-pushed
the
blue/executor-split
branch
from
19d0cc0 to
5dac94b
Compare
| payload: Payload, | ||
| max_workers: Optional[int] = None, | ||
| timeout: Optional[timedelta] = None, | ||
| budget: Optional[Union[float, Decimal]] = None, |
There was a problem hiding this comment.
hmm... why specify budget per task execution? ...
There was a problem hiding this comment.
@azawlocki do we want to leave it here? or remove it?
examples/blender/blender.py
Outdated
| @@ -12,6 +12,7 @@ | |||
| WorkContext, | |||
| windows_event_loop_fix, | |||
| ) | |||
| from yapapi.executor import Golem | |||
There was a problem hiding this comment.
That's most likely not the scope of this PR but it would be best to make this from yapapi import Golem, either by actually moving the code or just importing it in the base package.
There was a problem hiding this comment.
I would say this should be in the scope of the changes to be frozen - but I'll let @azawlocki decide if he'd like to proceed with reshuffling of code between the files within the scope of this pull request...
yapapi/executor/__init__.py
Outdated
| """ | ||
| logger.debug("Creating Executor instance; parameters: %s", locals()) | ||
| self._init_api(app_key) |
There was a problem hiding this comment.
_init_api is an internal one-liner which is used only here, I think it would be more readable if we just expanded it. Added bonus: it would make the fate of app_key slightly easier to follow (it's one less jump to make, the default env var substitution happens in Configuration#__init__).
yapapi/executor/__init__.py
Outdated
| # TODO: add message | ||
| logger.debug("TODO", exc_info=True) |
| async def _handle_proposal( | ||
| self, | ||
| proposal: OfferProposal, | ||
| demand_builder: DemandBuilder, |
There was a problem hiding this comment.
This should probably be an immutable representation of the demand rather than a builder object.
There was a problem hiding this comment.
seems like a good idea. @azawlocki what do you think?
yapapi/executor/__init__.py
Outdated
| # TODO: add message | ||
| logger.debug("TODO", exc_info=True) |
azawlocki
force-pushed
the
blue/executor-split
branch
3 times, most recently
from
c91830c to
b5dade5
Compare
azawlocki
force-pushed
the
blue/executor-split
branch
from
b5dade5 to
1973569
Compare
No description provided.