Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if modifying DemandBuilder in _handle_proposal() is not a bug #380

Closed
azawlocki opened this issue May 18, 2021 · 1 comment
Closed

Check if modifying DemandBuilder in _handle_proposal() is not a bug #380

azawlocki opened this issue May 18, 2021 · 1 comment
Assignees
@filipgolem
Labels
bug Something isn't working

Comments

@azawlocki
Copy link
Contributor

azawlocki commented May 18, 2021 •
edited by shadeofblue
Loading

A common instance of DemandBuilder is used for handling all offer proposals for a demand. Yet we modify it in _handle_proposal() when negotiating a single proposal. That may be a bug.

maybe we should act on @zakaprov's idea of only passing the properties/constraints to the handler so that we're sure they cannot be modified ... - or - maybe we should just construct a Demand object and pass that ? ... or use our "own" Demand dataclass / namedtuple that already has those properties/constraints frozen?
@azawlocki azawlocki self-assigned this May 18, 2021
@azawlocki azawlocki added the bug Something isn't working label May 18, 2021
@azawlocki azawlocki mentioned this issue May 20, 2021
Merged
@johny-b johny-b assigned johny-b and unassigned azawlocki Dec 6, 2021
@johny-b johny-b assigned filipgolem and unassigned johny-b Feb 4, 2022
@filipgolem
Copy link
Contributor

#864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipgolem filipgolem

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@azawlocki @johny-b @filipgolem