Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple service toy prototype #303
simple service toy prototype #303
Changes from 61 commits
20c989a
948fd65
9880630
982d7df
69bcdfc
0665865
adc5972
3e4b0a8
3524e5b
cab9f94
f92b448
5a776a6
f851124
942f46b
32ae650
4a2081d
ccb307e
eec0510
ccedf05
f8eeeda
9854fc4
8f1065e
a55f667
338eceb
6d171a3
e6563fd
d6e5a35
10de416
474565b
554abcc
b05ccc6
9afefd5
e1fdffe
ac1e43a
8f46907
1ff0c4b
4467388
cbf48af
27ffa59
2e7d5f6
9f71db2
2a2717d
3861b3a
f809854
73ba1fd
abf2211
9eee66f
b821a55
2e5f575
99a7845
e053519
0ee6c70
cafd93c
290a305
033e5db
b7b197a
43c0146
cdadb30
8037417
a9f4915
c7cbd5b
0ed9598
ae7b8c0
57f2c48
ab9d278
44f826e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the example would be more readable if we moved these out of
main()
? That would require adding ac: Cluster
parameter.Or maybe even have a
print_instances(cluster)
function?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments, I wouldn't do pull those out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Test http" an accurate description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, no :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 57f2c48