simple service toy prototype #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mfactory/yapapi into blue/polling-batch-timeout-argument
… and server-side timeouts.
azawlocki
reviewed
May 27, 2021
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| parser = build_parser("Test http") |
There was a problem hiding this comment.
Is "Test http" an accurate description?
There was a problem hiding this comment.
done in 57f2c48
azawlocki
reviewed
May 27, 2021
Comment on lines
+111
to
+116
| def instances(): | ||
| return [(s.provider_name, s.state.value) for s in cluster.instances] | ||
|
|
||
| def still_running(): | ||
| return any([s for s in cluster.instances if s.is_available]) | ||
|
|
There was a problem hiding this comment.
Maybe the example would be more readable if we moved these out of main()? That would require adding a c: Cluster parameter.
Or maybe even have a print_instances(cluster) function?
There was a problem hiding this comment.
I added some comments, I wouldn't do pull those out
azawlocki
approved these changes
May 27, 2021
azawlocki
reviewed
May 27, 2021
azawlocki
reviewed
May 27, 2021
…ons to .py files included within to make it obvious that these files are not part of the requestor agent
…he services have started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.