add a work-around to make the examples work on win+py3.6/3.7 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
suggested changes
Oct 22, 2020
| @@ -86,6 +86,8 @@ async def worker(ctx: WorkContext, tasks): | |||
| parser.set_defaults(log_file="blender-yapapi.log") | |||
| args = parser.parse_args() | |||
|
|
|||
| utils.asyncio_fix() | |||
|
|
|||
| enable_default_logger(log_file=args.log_file) | |||
| loop = asyncio.get_event_loop() | |||
There was a problem hiding this comment.
As a quick fix we may also consider:
if sys.platform == 'win32' and sys.version_info < (3, 8):
asyncio.set_event_loop(asyncio.ProactorEventLoop())
instead of calling utils.asyncio_fix()
There was a problem hiding this comment.
If we decide to go with a separate function in utils, I think the name needs to be improved to be more descriptive (e.g.: asyncio_windows_fix or even windows_event_loop_fix)
filipgolem
approved these changes
Oct 23, 2020
| @@ -4,7 +4,7 @@ build-backend = "poetry.masonry.api" | |||
|
|
|||
| [tool.poetry] | |||
| name = "yapapi" | |||
| version = "0.3.0" | |||
| version = "0.3.1-alpha.0" | |||
There was a problem hiding this comment.
I'd release it as 0.3.1.
There was a problem hiding this comment.
Sure, let's make pre-release first for 0.3.1-alpha.0, then bump the version to 0.3.1 and do a release.
There was a problem hiding this comment.
@filipgolem @azawlocki actually, if, despite my opinion to the contrary, we didn't update the library itself, imvho, it didn't even require a release ...
azawlocki
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backwards-compatible port of #105 which only fixes the examples but doesn't make the work-around part of the library