provide a fix for asyncio on Windows + Python pre-3.8 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ test + enable github actions test run on Python 3.9
…on supported on github actions
azawlocki
suggested changes
Oct 22, 2020
yapapi/__init__.py
Outdated
Comment on lines
27
to
32
| if sys.platform == "win32": | ||
|
|
||
| class _WindowsEventPolicy(asyncio.events.BaseDefaultEventLoopPolicy): | ||
| _loop_factory = asyncio.windows_events.ProactorEventLoop | ||
|
|
||
| asyncio.set_event_loop_policy(_WindowsEventPolicy()) |
There was a problem hiding this comment.
I'd just move those statements to the module level, outside any function
There was a problem hiding this comment.
then I'd need more "if sys.platform" etc since this class is not valid under non-Windows platforms ...
There was a problem hiding this comment.
ah, unless you mean the same as above - then, again, I'm unsure if this is a good idea to force that upon people ...
filipgolem
suggested changes
Nov 16, 2020
filipgolem
approved these changes
Nov 16, 2020
azawlocki
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #93