-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve json output for CommandOutput::Table #1723
improve json output for CommandOutput::Table #1723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. I would just rename some variables (see suggestions).
dd12798
to
0ccb69c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Consider changing "not any not equal" to "all equal": #1723 (comment)
{"headers": [...], "values": [[...]]} -> [{"header": "value"}] resolve golemfactory#906
0ccb69c
to
565c712
Compare
Hey @biryukovmaxim Thanks for your contribution!
The first 2 should be simple, after updating to master we can see the goth build run and make an issue in the For the last one i made a note on our board, we will look into this and update you here :) |
I would suggest a further refactoring (may be as a next step after this PR), to change pub struct ResponseTable {
pub columns: Vec<String>,
pub values: Vec<serde_json::Value>,
} to pub struct ResponseTable<T: serde::Serialize>(Vec<T>); or something like that. |
We updated all tools depending on this code. |
{"headers": [...], "values": [[...]]} -> [{"header": "value"}]
resolve #906