Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better json output from commands #906

Closed
etam opened this issue Jan 8, 2021 · 1 comment · Fixed by #1723
Closed

better json output from commands #906

etam opened this issue Jan 8, 2021 · 1 comment · Fixed by #1723
Labels
enhancement New feature or request good first issue Good for newcomers slacktime ux

Comments

@etam
Copy link
Contributor

etam commented Jan 8, 2021 •
edited by nieznanysprawiciel
Loading

Current structure example:
yagna --json id list

{
  "headers": [
    "default",
    "locked",
    "alias",
    "address"
  ],
  "values": [
    [
      "X",
      "",
      null,
      "0x9657978563b470cecef3822bf7a103cdf0aed1e6"
    ]
  ]
}

Better format proposal:

[
  {
    "default": "X",
    "locked": "",
    "alias": null,
    "address": "0x9657978563b470cecef3822bf7a103cdf0aed1e6"
  }
]

Dependencies:

  • GOTH
  • checkers

How this apply to compatibility policy??
@etam etam added the enhancement New feature or request label Jan 8, 2021
@nieznanysprawiciel nieznanysprawiciel added the good first issue Good for newcomers label Sep 5, 2021
biryukovmaxim added a commit to biryukovmaxim/yagna that referenced this issue Nov 28, 2021
@biryukovmaxim
json CommandOutput::Table:
dd12798 
{"headers": [...], "values": [[...]]} -> [{"header": "value"}]
resolve golemfactory#906
@biryukovmaxim biryukovmaxim mentioned this issue Nov 28, 2021
Merged
@biryukovmaxim
Copy link
Contributor

Hello, I tryed to solve it!
Could someone watch my pr?

biryukovmaxim added a commit to biryukovmaxim/yagna that referenced this issue Nov 29, 2021
@biryukovmaxim
json CommandOutput::Table:
0ccb69c 
{"headers": [...], "values": [[...]]} -> [{"header": "value"}]
resolve golemfactory#906
biryukovmaxim added a commit to biryukovmaxim/yagna that referenced this issue Dec 1, 2021
@biryukovmaxim
json CommandOutput::Table:
565c712 
{"headers": [...], "values": [[...]]} -> [{"header": "value"}]
resolve golemfactory#906
maaktweluit pushed a commit that referenced this issue Feb 21, 2022
@biryukovmaxim @maaktweluit
json CommandOutput::Table:
491fafa 
{"headers": [...], "values": [[...]]} -> [{"header": "value"}]
resolve #906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers slacktime ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve json output for CommandOutput::Table biryukovmaxim/yagna
4 participants
@etam @nieznanysprawiciel @tworec @biryukovmaxim