Move goth integration tests to yagna repo #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmazurek
changed the title
This was referenced Apr 20, 2021
kmazurek
requested review from
azawlocki,
nieznanysprawiciel,
shadeofblue,
tworec,
pnowosie and
maaktweluit
azawlocki
reviewed
Apr 20, 2021
azawlocki
reviewed
Apr 20, 2021
azawlocki
reviewed
Apr 20, 2021
| ... | ||
| ): | ||
| goth_config = load_yaml(Path("path/to/goth-config.yml", config_overrides) | ||
| ``` |
There was a problem hiding this comment.
This README is excellent!
There was a problem hiding this comment.
Indeed. Much appreciated effort @zakaprov
azawlocki
reviewed
Apr 20, 2021
shadeofblue
reviewed
Apr 20, 2021
goth_tests/README.md
Outdated
|
|
||
| ### Project setup | ||
| Below are the steps you need to take in order to prepare your environment for running this integration test suite. | ||
| > Please not that currently the only supported platform is **Linux** with **Python 3.8+**. |
There was a problem hiding this comment.
Suggested change
| > Please not that currently the only supported platform is **Linux** with **Python 3.8+**. | |
| > Please note that currently the only supported platform is **Linux** with **Python 3.8+**. |
There was a problem hiding this comment.
Updated in 31cfad0
azawlocki
reviewed
Apr 20, 2021
azawlocki
reviewed
Apr 20, 2021
azawlocki
previously approved these changes
Apr 20, 2021
nieznanysprawiciel
previously approved these changes
Apr 20, 2021
kmazurek
dismissed stale reviews from nieznanysprawiciel and azawlocki
via
09dfb86
azawlocki
previously approved these changes
Apr 21, 2021
Adds files necessary for running goth tests as part of yagna repository. This also includes moving the VM E2E test from goth to yagna.
|
Heads up: I'm doing an interactive rebase before merging to get rid of some redundant commits. |
tworec
reviewed
Apr 21, 2021
| If a test requires custom assets (e.g. VM Blender test) they should be placed in a directory named `assets` alongside the test `.py` file itself. | ||
|
|
||
| ### How these tests work | ||
| Every `goth` test operates on an isolated, local network of `yagna` nodes which gets created using Docker. Besides the `yagna` containers themselves this network also includes components such as `ya-sb-router` or `ganache` local blockchain. |
There was a problem hiding this comment.
Suggested change
| Every `goth` test operates on an isolated, local network of `yagna` nodes which gets created using Docker. Besides the `yagna` containers themselves this network also includes components such as `ya-sb-router` or `ganache` local blockchain. | |
| Every `goth` test operates on an isolated, local network of `yagna` nodes which gets created using Docker. Besides the `yagna` containers themselves this network also includes components such as `ya-sb-router` (used for instantiating owned local yagna networking) or `ganache` local blockchain. |
tworec
reviewed
Apr 21, 2021
| 2. The test runner creates a number of Yagna containers (as defined in `goth-config.yml`) which are connected to the `docker-compose` network. | ||
| 3. For each Yagna container started a so-called "probe" object is created and made available inside the test via the `Runner` object. | ||
| 4. The integration test scenario is executed as defined in the function called by `pytest`. | ||
| 5. Once the test is finished, all previously started Docker containers (both "static" and "dynamic") are removed. |
There was a problem hiding this comment.
I'd mention "dynamic" within point 2. as you did with "static" in 1.
maaktweluit
pushed a commit
that referenced
this pull request
May 24, 2021
Move goth integration tests to yagna repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: golemfactory/goth#401