Enable overriding values in goth config file #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
reviewed
Apr 15, 2021
| def test_load_yaml_override_new(default_config_file: Path): | ||
| """Test adding a new field to a YAML config file through overrides.""" | ||
|
|
||
| test_value = "v0.0.1-rc666" |
azawlocki
reviewed
Apr 15, 2021
|
|
||
| def _apply_overrides(dict_: Dict[str, Any], overrides: List[Override]): | ||
| for (dict_path, value) in overrides: | ||
| path_list: List[str] = dict_path.split(".") |
There was a problem hiding this comment.
I think you could also allow ints in path_list and then override like this:
overrides = [("nodes.1.name", "dostawca-1")] # path_list = ["nodes", 1, "name"]
config = load_yaml(default_config_file, overrides)
assert config.containers[1].name == "dostawca-1"
But it's probably not worth doing, if we ever need to identify config elements based on list indices then it would be probably an indication that the relevant part of the configuration tree should be made a dir instead of a list.
There was a problem hiding this comment.
I think it's better to limit ourselves to dicts for now. The only use-cases I see for list access in our current config file is for debugging purposes. As such, this can be achieved by editing the file itself, rather than using overrides.
With that said I'm going to mention the limitation to dict in the docstring for load_yaml.
azawlocki
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary as part of golemfactory/yagna#1235 (i.e. moving integration tests from
gothtoyagnarepos).Adds the possibility to override certain fields in
goth-config.ymldynamically, i.e. when the file gets parsed. This is implemented with an additional parameter togoth/configuration.py#load_yamlwhich is a list of values to override. Here's an example of one such list: