Restore reverse connection #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieznanysprawiciel
force-pushed
the
restore-reverse-connection
branch
from
a0c824f to
87ede5e
Compare
nieznanysprawiciel
force-pushed
the
restore-reverse-connection
branch
from
0822fb7 to
7b31748
Compare
Closed
MrDarthShoe
approved these changes
Jul 11, 2023
| @@ -1340,7 +1392,7 @@ impl Handler for SessionLayer { | |||
| Some(session) => session, | |||
| }; | |||
|
|
|||
| let node = if slot == FORWARD_SLOT_ID { | |||
| let sender = if is_direct_message(slot) { | |||
| // Direct message from other Node. | |||
…tion Test closing relayed connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #246
Additional changes:
ya-relay-serverto return neighborhood properly, when public key was not requestedTested with yagna to reproduce bug: golemfactory/yagna#2501
I ran yagna a few times with neighborhood set to 50 Nodes and problem didn't occur.
But in general I had problems running yagna with so big neighborhood. Requests to
ya-relay-serverwere timeouting most of the times. I suspected that this is due to too large neighborhood packets (#139) being dropped by my router, becauseya-relay-serversends response.As a conclusion: we need to still observe if deadlock will occur again.