Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore ReverseConnection functionality #246

Closed
nieznanysprawiciel opened this issue Jun 21, 2023 · 0 comments · Fixed by #250
Closed

Restore ReverseConnection functionality #246

nieznanysprawiciel opened this issue Jun 21, 2023 · 0 comments · Fixed by #250
Assignees
@nieznanysprawiciel

Comments

@nieznanysprawiciel
Copy link
Contributor

nieznanysprawiciel commented Jun 21, 2023 •
edited
Loading

Acceptance criteria:

  • If at least 1 of Nodes has public IP, we should be able to create p2p connection
  • Make sure we don't have deadlock problem anymore: NET - deadlock during ReverseConnection yagna#2501
  • Use states mechanisms to allow incoming session initialization (normally when we are during initialization, we don't allow any other attempts to connect, here we are waiting for connection and we are blocking all outgoing attempts at the same time)

Additional things to solve:

  • SessionLayer is attempting different connections if previous failed. Make sure that SessionState is set properly, so this functionality will work properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nieznanysprawiciel nieznanysprawiciel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore reverse connection golemfactory/ya-relay
2 participants
@nieznanysprawiciel @staszek-krotki