-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Describe shortcomings. #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the last comment is blocking.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @dopiera)
arch-snapshot/arch.md
line 2403 at r1 (raw file):
irrespective of whether they were intentional or unintentional. ### Lack of Network Decentralization
Centralized solutions have inherent benefits that decentralized implementation's can't have. Discovery is orders of magnitude faster, NAT holepunching is not always reliable, etc. I'm not sure if it's worth pointing out here though.
arch-snapshot/arch.md
line 2427 at r1 (raw file):
This separation could potentially allow the reuse of [libp2p](https://libp2p.io/) for the first two layers, reducing the need for
There has been an attempt on porting yagna to libp2p, but I've no idea whether the findings were listed anywhere. You can try asking Witek about it -- maybe it could shed some more light on this issue.
arch-snapshot/arch.md
line 2456 at r1 (raw file):
supply over request volume. ### Limited Offer Query Language
I don't like LDAP at all, but is it actually insufficient in real use-cases? If you have an example maybe you could add it here.
The description only lists the large ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @kamirr)
arch-snapshot/arch.md
line 2403 at r1 (raw file):
Previously, kamirr (Kamil Koczurek) wrote…
Centralized solutions have inherent benefits that decentralized implementation's can't have. Discovery is orders of magnitude faster, NAT holepunching is not always reliable, etc. I'm not sure if it's worth pointing out here though.
Right, but decentralization is a requirement for us. Let me state this more clearly.
arch-snapshot/arch.md
line 2427 at r1 (raw file):
Previously, kamirr (Kamil Koczurek) wrote…
There has been an attempt on porting yagna to libp2p, but I've no idea whether the findings were listed anywhere. You can try asking Witek about it -- maybe it could shed some more light on this issue.
We chatted briefly. Clearly there are pros and cons but I have not seen a comprehensive list of both. Do you think this point needs to be amended somehow?
arch-snapshot/arch.md
line 2456 at r1 (raw file):
Previously, kamirr (Kamil Koczurek) wrote…
I don't like LDAP at all, but is it actually insufficient in real use-cases? If you have an example maybe you could add it here.
PTAL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dopiera)
arch-snapshot/arch.md
line 2403 at r1 (raw file):
Previously, dopiera (Marek Dopiera) wrote…
Right, but decentralization is a requirement for us. Let me state this more clearly.
lgtm
arch-snapshot/arch.md
line 2427 at r1 (raw file):
Previously, dopiera (Marek Dopiera) wrote…
We chatted briefly. Clearly there are pros and cons but I have not seen a comprehensive list of both. Do you think this point needs to be amended somehow?
No, if there's no comprehensive list then it's fine to keep this point as it is
arch-snapshot/arch.md
line 2456 at r1 (raw file):
Previously, dopiera (Marek Dopiera) wrote…
PTAL.
lgtm, thanks
The description only lists the large ones.
This change is