Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format source based on eslint xo shared configuration #81

Merged
merged 3 commits into from
Nov 12, 2016
Merged

Format source based on eslint xo shared configuration #81

merged 3 commits into from
Nov 12, 2016

Commits on Nov 12, 2016

  1. Convert jshint rules and format codebase

    @dinoboff
    dinoboff committed Nov 12, 2016
    Configuration menu
    Copy the full SHA
    c111f1e View commit details
    Browse the repository at this point in the history

  2. Format source for consistency base on xo rules 

    XO overrides:
- set source mode to script instead of module.
- indent with space.
- allow non strict comparison to null.
- allow use before define for constructors.
- allow one line brace style.
- one var for uninitialised vars.
- no space before function paren.

XO Extensions:
- Only use features supported by node +4.3.
- no var (use const or let).
- no confusing arrow function body.
- use bracket for arrow function body as needed.
- new line after variables declaration.
- one line around ‘use strict’.
- require object shorthand.
- prefer arrow callback.
- prefer const.
    @dinoboff
    dinoboff committed Nov 12, 2016
    Configuration menu
    Copy the full SHA
    2aac310 View commit details
    Browse the repository at this point in the history

  3. run lint in CI tests

    @dinoboff
    dinoboff committed Nov 12, 2016
    Configuration menu
    Copy the full SHA
    481529a View commit details
    Browse the repository at this point in the history