Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format source based on eslint xo shared configuration #81

Merged
merged 3 commits into from
Nov 12, 2016

Conversation

dinoboff
Copy link
Collaborator

@dinoboff dinoboff commented Nov 12, 2016

Since the next branch modifies most of the source code, we might as well reformat it now and ensure consistent style in the future.

The process:

  • convert jshint config to eslint (and fix jshint config to some extend).
  • format source code.
  • test formatting in CI.
  • add command to fix formatting issue.
  • add command to report formatting issues with html reporter.
  • add contributing notes.

XO overrides:

  • set source mode to script instead of module.
  • indent with space.
  • allow non strict comparison to null.
  • allow use before define for constructors.
  • allow one line brace style.
  • one var for uninitialised vars.
  • no space before function paren.

XO Extensions:

  • Only use features supported by node +4.3.
  • no var (use const or let).
  • no confusing arrow function body.
  • use bracket for arrow function body as needed.
  • new line after variables declaration.
  • one line around ‘use strict’.
  • require object shorthand.
  • prefer arrow callback.
  • prefer const.

XO overrides:
- set source mode to script instead of module.
- indent with space.
- allow non strict comparison to null.
- allow use before define for constructors.
- allow one line brace style.
- one var for uninitialised vars.
- no space before function paren.

XO Extensions:
- Only use features supported by node +4.3.
- no var (use const or let).
- no confusing arrow function body.
- use bracket for arrow function body as needed.
- new line after variables declaration.
- one line around ‘use strict’.
- require object shorthand.
- prefer arrow callback.
- prefer const.
@dinoboff dinoboff added this to the 3.0 milestone Nov 12, 2016
@dinoboff dinoboff merged commit b81e30d into goldibex:next Nov 12, 2016
@dinoboff dinoboff deleted the eslint-format branch December 9, 2016 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant