Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopls: add Go version to automated issue reports #1338

Closed
findleyr opened this issue Mar 14, 2021 · 6 comments
Closed

gopls: add Go version to automated issue reports #1338

findleyr opened this issue Mar 14, 2021 · 6 comments
Labels
FrozenDueToAge

Comments

@findleyr
Copy link
Member

When I get CCed on gopls issues related to go/* libraries, my first question is always which version of Go is being used.

Can we include this information in our automated issue reports?

CC @hyangah @stamblerre
@hyangah
Copy link
Contributor

hyangah commented Mar 15, 2021

Do you want both go versions

  1. one used in building the gopls

  2. another that ** may be ** used by the gopls?

  3. can be still different from what gopls actually uses in rare cases (due to a bug in PATH mapping, or due to users' configuration).

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/301749 mentions this issue: internal/lsp/debug: add go version information to gopls version output

@findleyr
Copy link
Member Author

Thanks, I think we want both. Mailed https://golang.org/cl/301749 to add runtime.Version() to the gopls version command.

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/302832 mentions this issue: src/goLanguageServer: always check the version before crash report

gopherbot pushed a commit that referenced this issue Mar 18, 2021
@hyangah
src/goLanguageServer: always check the version before crash report
73e7c36 
For dev-version, we still not enforce update (this case should be
clear enough to tell apart from the gopls version included in the
issue report and is valuable to detect crash report during dev
period).

And
 - Add go version used by the extension and the update flag info.
 - Update gopls latestVersion to v0.6.8.

Updates #1300
Updates #1334
Updates #1338

Change-Id: I9965297b164665056dbec68285eb740ec2908f01
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/302832
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/303051 mentions this issue: [release] src/goLanguageServer: always check the version before crash report

gopherbot pushed a commit that referenced this issue Mar 19, 2021
@hyangah
[release] src/goLanguageServer: always check the version before crash…
e5c7441 
… report

For dev-version, we still not enforce update (this case should be
clear enough to tell apart from the gopls version included in the
issue report and is valuable to detect crash report during dev
period).

And
 - Add go version used by the extension and the update flag info.
 - Update gopls latestVersion to v0.6.8.

Updates #1300
Updates #1334
Updates #1338

Change-Id: I9965297b164665056dbec68285eb740ec2908f01
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/302832
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
(cherry picked from commit 73e7c36)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/303051
@golang golang deleted a comment from gopherbot Apr 1, 2021
@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@stamblerre
Copy link
Contributor

Closing because I believe this has been resolved.

@stamblerre stamblerre removed this from the Untriaged milestone Apr 9, 2021
@golang golang locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hyangah @stamblerre @gopherbot @findleyr