Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📌 v0.23.1+ requires gopls 0.6.6 or newer #1300

Closed
hyangah opened this issue Mar 12, 2021 · 9 comments
Closed

📌 v0.23.1+ requires gopls 0.6.6 or newer #1300

hyangah opened this issue Mar 12, 2021 · 9 comments
Labels
FrozenDueToAge

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 12, 2021 •
edited
Loading

Please update gopls if you see errors like the following

Starting client failed
  Message: JSON RPC parse error: json: cannot unmarshal number into Go struct field RenameClientCapabilities.capabilities.textDocument.rename.prepareSupportDefaultBehavior of type bool: JSON RPC parse error
  Code: -32700

or

Screen Shot 2021-03-11 at 8 28 59 PM

Choose to update it.

If the above popup didn't appear (maybe because GOPROXY isn't reachable)
Run Ctrl+Shift+P -> "Go: Install/Update Tools" -> Select gopls -> OK

Screen Shot 2021-03-11 at 8 30 18 PM

Or, if you want to install it manually,

  GO111MODULE=on go get golang.org/x/tools/gopls@latest
@hyangah hyangah pinned this issue Mar 12, 2021
This was referenced Mar 12, 2021
Closed
Closed
Closed
Closed
Closed
@hyangah hyangah changed the title v0.23.1 requires gopls 0.6.6 or newer 📌 v0.23.1 requires gopls 0.6.6 or newer Mar 12, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/301149 mentions this issue: src/goTools: update min/latest gopls version to 0.6.6

This was referenced Mar 12, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
gopherbot pushed a commit that referenced this issue Mar 12, 2021
@hyangah
src/goTools: update min/latest gopls version to 0.6.6
90370ab 
From https://proxy.golang.org/golang.org/x/tools/gopls/@v/v0.6.6.info
{"Version":"v0.6.6","Time":"2021-02-22T19:32:25Z"}

For #1300

Change-Id: I2d4059d913d0e0fa70b908292ab7e179ee741759
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/301149
Trust: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/301151 mentions this issue: [release] src/goTools: update min/latest gopls version to 0.6.6

This was referenced Mar 12, 2021
Closed
Closed
gopherbot pushed a commit that referenced this issue Mar 12, 2021
@hyangah
[release] src/goTools: update min/latest gopls version to 0.6.6
0ffe2e1 
From https://proxy.golang.org/golang.org/x/tools/gopls/@v/v0.6.6.info
{"Version":"v0.6.6","Time":"2021-02-22T19:32:25Z"}

For #1300

Change-Id: I2d4059d913d0e0fa70b908292ab7e179ee741759
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/301149
Trust: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
(cherry picked from commit 90370ab)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/301151
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
@hyangah
Copy link
Contributor Author

hyangah commented Mar 12, 2021

v0.23.2 that explicitly states the hard-coded minimum required gopls version (v0.6.6) is released.
Users with old gopls will be notified to update it.

Thank you for your patience.

@hyangah hyangah closed this as completed Mar 12, 2021
@hyangah hyangah changed the title 📌 v0.23.1 requires gopls 0.6.6 or newer 📌 v0.23.1+ requires gopls 0.6.6 or newer Mar 12, 2021
@hyangah hyangah mentioned this issue Mar 12, 2021
Closed
@hyangah hyangah mentioned this issue Mar 18, 2021
Closed
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/302832 mentions this issue: src/goLanguageServer: always check the version before crash report

This was referenced Mar 18, 2021
Closed
Closed
Closed
Closed
gopherbot pushed a commit that referenced this issue Mar 18, 2021
@hyangah
src/goLanguageServer: always check the version before crash report
73e7c36 
For dev-version, we still not enforce update (this case should be
clear enough to tell apart from the gopls version included in the
issue report and is valuable to detect crash report during dev
period).

And
 - Add go version used by the extension and the update flag info.
 - Update gopls latestVersion to v0.6.8.

Updates #1300
Updates #1334
Updates #1338

Change-Id: I9965297b164665056dbec68285eb740ec2908f01
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/302832
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/303051 mentions this issue: [release] src/goLanguageServer: always check the version before crash report

@piyushsingariya
Copy link

This is still happening to vscode. Can somebody guide I updated gopls still vscode-go says to update, I restarted the gopls server still not getting started.

gopherbot pushed a commit that referenced this issue Mar 19, 2021
@hyangah
[release] src/goLanguageServer: always check the version before crash…
e5c7441 
… report

For dev-version, we still not enforce update (this case should be
clear enough to tell apart from the gopls version included in the
issue report and is valuable to detect crash report during dev
period).

And
 - Add go version used by the extension and the update flag info.
 - Update gopls latestVersion to v0.6.8.

Updates #1300
Updates #1334
Updates #1338

Change-Id: I9965297b164665056dbec68285eb740ec2908f01
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/302832
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
(cherry picked from commit 73e7c36)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/303051
@stamblerre
Copy link
Contributor

@piyushsingariya: Please take a look at the troubleshooting guide and open a new issue so we can help you investigate.

This was referenced Mar 22, 2021
Closed
Closed
@stamblerre stamblerre mentioned this issue Mar 24, 2021
Closed
@hyangah hyangah unpinned this issue Mar 30, 2021
@hyangah hyangah mentioned this issue Mar 31, 2021
Closed
@suzmue suzmue modified the milestone: v0.24.0 Mar 31, 2021
@findleyr findleyr mentioned this issue Apr 20, 2021
Closed
@findleyr findleyr mentioned this issue May 10, 2021
Closed
@kemalelmizan kemalelmizan mentioned this issue Jun 15, 2021
Closed
@hyangah hyangah mentioned this issue Jun 18, 2021
Closed
This was referenced Jul 7, 2021
Closed
Closed
Closed
@findleyr findleyr mentioned this issue Aug 5, 2021
Closed
@findleyr findleyr mentioned this issue Sep 8, 2021
Closed
@hyangah hyangah mentioned this issue Oct 29, 2021
Closed
@golang golang locked and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@hashbender @hyangah @stamblerre @suzmue @gopherbot @piyushsingariya