Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: reinstate 'go.languageServerExperimentalFeatures.diagnostics' #1110

Closed
hyangah opened this issue Jan 21, 2021 · 2 comments
Closed

settings: reinstate 'go.languageServerExperimentalFeatures.diagnostics' #1110

hyangah opened this issue Jan 21, 2021 · 2 comments
Assignees
@hyangah
Labels
FrozenDueToAge
Milestone
v0.21.1

Comments

@hyangah
Copy link
Contributor

hyangah commented Jan 21, 2021

v0.21.0 removed the flag, but the flag has been used as a workaround for #1109.
@hyangah hyangah self-assigned this Jan 21, 2021
@hyangah hyangah added this to the v0.21.1 milestone Jan 21, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/285253 mentions this issue: src/goLanguageServer: partial revert of cl/280601

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/285256 mentions this issue: [release] src/goLanguageServer: partial revert of cl/280601

gopherbot pushed a commit that referenced this issue Jan 21, 2021
@hyangah
[release] src/goLanguageServer: partial revert of cl/280601
ea221fb 
This partially reverts commit 4c91c38.

In https://go-review.googlesource.com/c/vscode-go/+/280601,
we tried to remove the languageServerExperimentalFeatures setting
because gopls's diagnostics feature is no longer in its experimental
state and that was the only flag left in this setting.

However, we learned some users depend on this flag because the
extension turns off buildOnSave and vetOnSave features when gopls's
diagnostics is used and they need to run custom vet analyzers.
This is not ideal and the extension shouldn't prevent users from
running their custom analyzers. That needs more investigation and
experiment.

For now, we rollback the change, but place the deprecation notice.

Update #50
Fixes #1110

Change-Id: I376692b152d3011aaa8da7a1b5121ba33e2188b6
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/285253
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
(cherry picked from commit fbd2fc4)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/285256
@golang golang locked and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hyangah hyangah

Labels
FrozenDueToAge
Projects
None yet
Milestone
v0.21.1
Development

No branches or pull requests
2 participants
@hyangah @gopherbot