Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check: allow use of custom vet when using the language server #1109

Closed
hyangah opened this issue Jan 21, 2021 · 3 comments
Closed

check: allow use of custom vet when using the language server #1109

hyangah opened this issue Jan 21, 2021 · 3 comments

Comments

@hyangah
Copy link
Contributor

hyangah commented Jan 21, 2021

From #50 -
some users had to turn off gopls diagnostics because they need custom vet analyzers.
Find a way for users to turn on the vet.

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/285253 mentions this issue: src/goLanguageServer: partial revert of cl/280601

@tamayika
Copy link
Contributor

I gave up to run go vet with vscode-go and made vscode-any-lint to support multiple lint tools for any files.
Thanks to this extension, I got both gopls's diagnostics and custom analyzer's diagnostics.
So, if there is nobody who wants custom vet with gopls, please close this issue and deprecate custom vet with gopls feature.

@gopherbot gopherbot added this to the Untriaged milestone Apr 8, 2021
@stamblerre stamblerre modified the milestones: Untriaged, Backlog Apr 9, 2021
@hyangah
Copy link
Contributor Author

hyangah commented Jan 18, 2022

Let's close this - users who want to use a custom vet should consider

@hyangah hyangah closed this as completed Jan 18, 2022
@golang golang locked and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants