-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/env/openbsd: add OpenBSD 6.8 builder #35712
Comments
Only OpenBSD 6.5 and 6.6 are currently supported releases - I'd suggest running builders for both of these versions and retiring the older ones. |
OpenBSD 6.7 has just been released - 6.6 and 6.7 are now the only currently supported releases. We really need to new builders up and retire the 6.2 and 6.4 builders... |
@4a6f656c Thanks for the reminder. I will follow up on this soon. |
FWIW OpenBSD 6.8 has recently been released - 6.7 and 6.8 are now the only currently supported releases. |
In #42237 (comment), @4a6f656c kindly offered to help by providing a script that produces a OpenBSD image, but someone with permissions on @golang/release team is needed to review the CLs and push/deploy the builder. @cagedmantis You're currently assigned on this issue from before, do you still want to work on this and have the bandwidth to take it up? If so, I'll let you coordinate with Joel on the timing you prefer (perhaps the coming weeks, or maybe after Go 1.16 final is out), otherwise please feel free to un-assign so someone else can pick this up when they have an opportunity. Thanks. |
@dmitshur I've removed myself as the assignee. Please feel free to work on this issue if you have the time. I will attempt to work on this issue in the future if time permits. |
@4a6f656c If things go well, I should have the bandwidth to review and deploy. If we run into problems that require more debugging, I might have to put this on hold until after Go 1.16 is out. Please feel free to send a CL to x/build, and set |
Change https://golang.org/cl/268297 mentions this issue: |
Update the openbsd-{386,amd64} builder script to create OpenBSD 6.8 images. Updates golang/go#35712 Change-Id: I7b306f7c99c02ae0c2eab57bdf2c463b11aa507f Reviewed-on: https://go-review.googlesource.com/c/build/+/268297 Trust: Joel Sing <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
@dmitshur - the script changes have landed and the images built for 386/amd64 work correctly locally. Please let me know if you hit any issues getting these running on GCE. |
Change https://golang.org/cl/269577 mentions this issue: |
Here are some failures I ran into while testing a new 64-bit OpenBSD 6.8 builder with
From one run:
Here's another run:
At first glance, given the failures are sporadic, there's a chance this could somehow be related to #42542 (CC @bcmills). I'll do some more testing, I just wanted to share the immediate results earlier. Specifically, I'll also try with Go 1.15 commits in addition to tip, in case there's a problem there. Update: So far, Go 1.15.4 (commit 0e953ad) has passed once, |
A recent tip commit has also passed on another run, so perhaps there's some intermittent problem. I'll add this builder with a KnownIssue and without TryBots first, then we can decide how to proceed after we have more information from testing this builder on a wider set of commits. |
I've remembered all OpenBSD use |
This change builds on top of CL 268297, using the updated env script to build OpenBSD 6.8 images, and adding new builders that use them. This has been tested with cmd/debugnewvm on a recent Go tip commit, as well as Go 1.15.4 and 1.14.11 commits. It passed, although there were also some failures seen. Once the builder is added, we'll know the test results for a wider set of commits, and can decide how to proceed from there. Minimize the configuration to a bare minimum. Specifically, remove MinCPUPlatform since setting it "Intel Skylake" was found not to have a noticeable effect on the speed of the build compared to the zero value: # With MinCPUPlatform = "Intel Skylake": $ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4 [...] real 17m8.308s # With a zero MinCPUPlatform value: $ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4 [...] real 16m28.518s For golang/go#35712. Updates golang/go#42426. Change-Id: I517a85738a034a3a4074488ccecd4408a91a4a07 Reviewed-on: https://go-review.googlesource.com/c/build/+/269577 Trust: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> Reviewed-by: Carlos Amedee <[email protected]>
Now that a fix for #42542 is available via syspatch (see #42542 (comment)), I've re-run the scripts in The amd64 one was created without an error:
But the 386 one failed at the end with:
I'm not sure why that is. I'll try it again to find out whether it's intermittent or not. |
It succeeded on the second try:
|
Change https://golang.org/cl/277115 mentions this issue: |
Tested CL 277115 with debugnewvm, got "ALL TESTS PASSED" on both amd64 and 386 runs. I also got this failure once:
Going to proceed, since we still have a non-zero KnownIssue, and we'll find out more from the future commits on the build dashboard. |
For golang/go#35712. Updates golang/go#42542. Updates golang/go#42426. Change-Id: Ifbdd025b8d1708e715ba312c438f391e1aeaeff8 Reviewed-on: https://go-review.googlesource.com/c/build/+/277115 Trust: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Joel Sing <[email protected]>
This was the log when building the openbsd-amd64 image: Full Output
This part stood out:
That reads to me like maybe the patches didn't apply successfully, but I'm not familiar with the OpenBSD install process to be sure. |
A recent failure on openbsd-386-68 builder with the new image suggests the patch likely did not apply correctly, or did not have an effect:
https://build.golang.org/log/cfcd74b1b16c3d7874f7fcbee3f4d5dcffd8d9d9 @4a6f656c Are you able to help investigate this? Thanks. |
Change https://golang.org/cl/278732 mentions this issue: |
syspatch is currently being invoked at the end of the installation, which means we're trying to patch the installation ramdisk kernel, rather than the generic kernel. Instead, invoke syspatch during the first boot of the generic kernel. Move pkg_add as well, since that is also generally safer to run outside of the installation. Update golang/go#35712 Update golang/go#42542 Change-Id: Icbb384816de5859078a0183919626d223fb0060f Reviewed-on: https://go-review.googlesource.com/c/build/+/278732 Trust: Joel Sing <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Change https://golang.org/cl/279134 mentions this issue: |
These images were regenerated after the fix in CL 278732. For golang/go#35712. Updates golang/go#42542. Updates golang/go#42426. Change-Id: Ib9c9dc316e4f68e7fed2cafe5400942a94ba8fd2 Reviewed-on: https://go-review.googlesource.com/c/build/+/279134 Trust: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Joel Sing <[email protected]>
Change https://golang.org/cl/279512 mentions this issue: |
Change https://golang.org/cl/279723 mentions this issue: |
Change https://golang.org/cl/280052 mentions this issue: |
The goal in CL 279512 was to reduce numTryTestHelpers from 5 to 4, but it unintentionally set the field only in the 386 builder, not the amd64 one. This caused the amd64 OpenBSD TryBot to get very slow (20-25 minutes), making it very much a bottleneck for overall TryBot completion time. Also stop explicitly setting some fields in openbsd-amd64-62 builder that have no effect by now, to simplify configuration. For golang/go#17104. Updates golang/go#35712. Change-Id: I22823e4848cab65f11bde2a1cc70527929d0792d Reviewed-on: https://go-review.googlesource.com/c/build/+/279723 Trust: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]>
These tests are known to be failing on OpenBSD 6.8 and need investigation. The OpenBSD 6.8 builders are default TryBots now, so skip them to prevent people working on other packages from constantly getting a failure. Issue 42064 remains open to do the work of determining if the ipv6 package needs to be fixed, or if OpenBSD 6.8 has a problem and the test can be permanently skipped as unsupported. For golang/go#11811. Updates golang/go#42064. Updates golang/go#35712. Change-Id: I59883384e4dbce679cb1a4e8e2c3f0fa7983010b Reviewed-on: https://go-review.googlesource.com/c/net/+/280052 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> Trust: Dmitri Shuralyov <[email protected]>
Change https://golang.org/cl/314749 mentions this issue: |
Change https://golang.org/cl/314750 mentions this issue: |
Change https://golang.org/cl/314751 mentions this issue: |
…nBSD 6.8 builders These tests are known to be failing on OpenBSD 6.8 and need investigation. The OpenBSD 6.8 builders are default TryBots now, so skip them to prevent people working on other packages from constantly getting a failure. Issue 42064 remains open to do the work of determining if the ipv6 package needs to be fixed, or if OpenBSD 6.8 has a problem and the test can be permanently skipped as unsupported. For golang/go#11811. Updates golang/go#42064. Updates golang/go#35712. Change-Id: I59883384e4dbce679cb1a4e8e2c3f0fa7983010b Reviewed-on: https://go-review.googlesource.com/c/net/+/280052 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> Trust: Dmitri Shuralyov <[email protected]> (cherry picked from commit 6772e93) Reviewed-on: https://go-review.googlesource.com/c/net/+/314749 Trust: Katie Hockman <[email protected]> Run-TryBot: Katie Hockman <[email protected]> Reviewed-by: Katie Hockman <[email protected]>
…BSD 6.8 builders These tests are known to be failing on OpenBSD 6.8 and need investigation. The OpenBSD 6.8 builders are default TryBots now, so skip them to prevent people working on other packages from constantly getting a failure. Issue 42064 remains open to do the work of determining if the ipv6 package needs to be fixed, or if OpenBSD 6.8 has a problem and the test can be permanently skipped as unsupported. For golang/go#11811. Updates golang/go#42064. Updates golang/go#35712. Change-Id: I59883384e4dbce679cb1a4e8e2c3f0fa7983010b Reviewed-on: https://go-review.googlesource.com/c/net/+/280052 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> Trust: Dmitri Shuralyov <[email protected]> (cherry picked from commit 6772e93) Reviewed-on: https://go-review.googlesource.com/c/net/+/314751 Trust: Katie Hockman <[email protected]> Run-TryBot: Katie Hockman <[email protected]> Reviewed-by: Katie Hockman <[email protected]>
… builders These tests are known to be failing on OpenBSD 6.8 and need investigation. The OpenBSD 6.8 builders are default TryBots now, so skip them to prevent people working on other packages from constantly getting a failure. Issue 42064 remains open to do the work of determining if the ipv6 package needs to be fixed, or if OpenBSD 6.8 has a problem and the test can be permanently skipped as unsupported. For golang/go#11811. Updates golang/go#42064. Updates golang/go#35712. Change-Id: I59883384e4dbce679cb1a4e8e2c3f0fa7983010b Reviewed-on: https://go-review.googlesource.com/c/net/+/280052 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> Trust: Dmitri Shuralyov <[email protected]> (cherry picked from commit 6772e93) Reviewed-on: https://go-review.googlesource.com/c/net/+/314750 Trust: Katie Hockman <[email protected]> Reviewed-by: Katie Hockman <[email protected]>
OpenBSD 6.6 is out:
https://www.openbsd.org/66.html
Update our GCE builders. (rather, add a builder)
Pending CL https://go-review.googlesource.com/c/build/+/176237 does most the work (but using pre-release 6.5 instead of 6.6).
Just need to build it, test it (with x/build/cmd/debugnewvm) and configure it if it works.
/cc @cagedmantis @dmitshur @bcmills
The text was updated successfully, but these errors were encountered: