Skip to content

Commit

Permalink
dashboard: add OpenBSD 6.8 builders
Browse files Browse the repository at this point in the history
This change builds on top of CL 268297, using the updated env script
to build OpenBSD 6.8 images, and adding new builders that use them.

This has been tested with cmd/debugnewvm on a recent Go tip commit,
as well as Go 1.15.4 and 1.14.11 commits. It passed, although there
were also some failures seen. Once the builder is added, we'll know
the test results for a wider set of commits, and can decide how to
proceed from there.

Minimize the configuration to a bare minimum. Specifically, remove
MinCPUPlatform since setting it "Intel Skylake" was found not to
have a noticeable effect on the speed of the build compared to the
zero value:

	# With MinCPUPlatform = "Intel Skylake":
	$ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4
	[...]
	real	17m8.308s

	# With a zero MinCPUPlatform value:
	$ time debugnewvm -run-build=openbsd-amd64-68 -rev=go1.15.4
	[...]
	real	16m28.518s

For golang/go#35712.
Updates golang/go#42426.

Change-Id: I517a85738a034a3a4074488ccecd4408a91a4a07
Reviewed-on: https://go-review.googlesource.com/c/build/+/269577
Trust: Dmitri Shuralyov <[email protected]>
Run-TryBot: Dmitri Shuralyov <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Alexander Rakoczy <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
  • Loading branch information
dmitshur committed Nov 12, 2020
1 parent 5f7fe5e commit 3a574da
Showing 1 changed file with 28 additions and 0 deletions.
28 changes: 28 additions & 0 deletions dashboard/builders.go
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,22 @@ var Hosts = map[string]*HostConfig{
Notes: "OpenBSD 6.4; GCE VM is built from script in build/env/openbsd-386",
SSHUsername: "gopher",
},
"host-openbsd-amd64-68": &HostConfig{
VMImage: "openbsd-amd64-68",
machineType: "n1-highcpu-4",
buildletURLTmpl: "https://storage.googleapis.com/$BUCKET/buildlet.openbsd-amd64",
goBootstrapURLTmpl: "https://storage.googleapis.com/$BUCKET/gobootstrap-openbsd-amd64-go1_12.tar.gz",
Notes: "OpenBSD 6.8; GCE VM is built from script in build/env/openbsd-amd64",
SSHUsername: "gopher",
},
"host-openbsd-386-68": &HostConfig{
VMImage: "openbsd-386-68",
machineType: "n1-highcpu-4",
buildletURLTmpl: "https://storage.googleapis.com/$BUCKET/buildlet.openbsd-386",
goBootstrapURLTmpl: "https://storage.googleapis.com/$BUCKET/gobootstrap-openbsd-386-go1_12.tar.gz",
Notes: "OpenBSD 6.8; GCE VM is built from script in build/env/openbsd-386",
SSHUsername: "gopher",
},
"host-openbsd-arm-joelsing": &HostConfig{
IsReverse: true,
ExpectNum: 1,
Expand Down Expand Up @@ -1945,6 +1961,18 @@ func init() {
tryBot: explicitTrySet("sys"),
distTestAdjust: noTestDirAndNoReboot,
})
addBuilder(BuildConfig{
Name: "openbsd-amd64-68",
HostType: "host-openbsd-amd64-68",
distTestAdjust: noTestDirAndNoReboot,
KnownIssue: 35712,
})
addBuilder(BuildConfig{
Name: "openbsd-386-68",
HostType: "host-openbsd-386-68",
distTestAdjust: noTestDirAndNoReboot,
KnownIssue: 35712,
})
addBuilder(BuildConfig{
Name: "openbsd-arm-jsing",
HostType: "host-openbsd-arm-joelsing",
Expand Down

0 comments on commit 3a574da

Please sign in to comment.