-
Notifications
You must be signed in to change notification settings - Fork 1k
This is the new hash on my machine #86
Conversation
yeah gps changed to no longer include stdlib imports in the hashing calculations (derp). i think (read: really really hope) it'll be a lot more stable now. |
...however, i get a different one when i |
i'm gonna add a method to print the input components to the hash mechanism. This is just too annoying to debug without something like that. |
New func now exists, will have up a PR soon |
I assume some stuff changed in gps
So, even after #89 was merged my hash is still this new one. |
@sdboyer Can you point me back at the code gps uses to hash? I think I'd like to change it a bit (or at least understand it). |
@freeformz sure - hashing logic is in hash.go I'm working on some updates to it right now that will trim things down a little further - sdboyer/gps#125 |
I get a different hash now: "memo": "ef5a4c5ae6fa16e842be8c0bc1ce7128d5d3f4790ca444da9ed6eb0b9b4344fd", |
I'm almost done with the improvements to the input hashing algorithm - sdboyer/gps#143. I'm nearly done with the implementation; mostly I'm just finishing covering the bases with tests. There's a lot of subtle cases that should be clearly and explicitly documented/tested. There's not much point in worrying about this until that's done, as a) the algorithm will change and b) the output from the new |
I added a (hidden)
|
$ hoard hash-inputs
-CONSTRAINTS-
github.com/Masterminds/semver
b-2.x
github.com/Masterminds/vcs
svc-^1.8.0
github.com/pkg/errors
svc->=0.8.0, <1.0.0
github.com/sdboyer/gps
b-master
-IMPORTS/REQS-
github.com/Masterminds/semver
github.com/Masterminds/vcs
github.com/pkg/errors
github.com/sdboyer/gps
-IGNORES-
-OVERRIDES-
-ANALYZER-
hoard
0.0.1 |
The memo I get now is |
that's from a simple |
i've got the same digest, now. it's weird that i didn't commit with the same on sunday, but i may have taken a little shortcut that explains that. |
Yes |
I get |
I think this can be closed now, so doing so. |
I assume some stuff changed in gps. Discovered when I ran
dep status
and got nothing.