Skip to content
This repository has been archived by the owner on Feb 3, 2018. It is now read-only.

Do not include ineffectual constraints in hash #125

Closed
sdboyer opened this issue Dec 23, 2016 · 3 comments
Closed

Do not include ineffectual constraints in hash #125

sdboyer opened this issue Dec 23, 2016 · 3 comments
Labels
correctness
Milestone
v0.14.0

Comments

@sdboyer
Copy link
Owner

sdboyer commented Dec 23, 2016

When SolveParameters.RootManifest contains a ProjectConstraint for a project that is present in any of the imports described in SolveParameters.RootPackageTree, that ProjectConstraint should not be included when computing the input hash, as it will have no bearing on the solver, and thus is equivalent to not being present at all. As a rule, we try to reduce all cases that we can determine will not bear on solving to the same base/zero case, in order to minimize the possibility of spurious hash conflicts.
@sdboyer sdboyer added this to the v0.14.0 milestone Dec 23, 2016
This was referenced Jan 10, 2017
Open
Closed
Merged
@sdboyer
Copy link
Owner Author

sdboyer commented Jan 14, 2017

Fixed in #139

@sdboyer sdboyer closed this as completed Jan 14, 2017
@sdboyer sdboyer reopened this Jan 14, 2017
@sdboyer
Copy link
Owner Author

sdboyer commented Jan 14, 2017

Not actually done yet, see #143

@sdboyer
Copy link
Owner Author

sdboyer commented Jan 17, 2017

done again/actually now

@sdboyer sdboyer closed this as completed Jan 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
correctness
Projects
None yet
Milestone
v0.14.0
Development

No branches or pull requests
1 participant
@sdboyer