This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
dep: update calculatePrune to not assume "/" as file separator #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test for dep.calculatePrune Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho
force-pushed
the
fix-prune-bug-on-windows
branch
from
0c1c8ea to
07d30f6
Compare
|
I didn't look deep in the code, but maybe it should call |
ibrasho
force-pushed
the
fix-prune-bug-on-windows
branch
from
07d30f6 to
a9cd3d8
Compare
|
Actually, the |
ibrasho
force-pushed
the
fix-prune-bug-on-windows
branch
3 times, most recently
from
05e9e87 to
0016724
Compare
|
@darkowlzz I think we can merge this now. But I'll like another pair of eyes to ensure I didn't miss anything. 😁 |
darkowlzz
reviewed
Jun 22, 2017
txn_writer_test.go
Outdated
| } | ||
|
|
||
| if !reflect.DeepEqual(want, got) { | ||
| t.Fatalf("expected %s, got %s", want, got) |
There was a problem hiding this comment.
Let's make this more informative. Previously, I used to do the same but Sam asked me to make the failures more informative. Something like:
t.Fatalf("Calculated prune paths are not as expected: \n\t(GOT) %v\n\t(WNT) %v", got, want)
There was a problem hiding this comment.
Makes total sense. 👍
There was a problem hiding this comment.
I've removed the tabs since they are not needed here. An error would like this now:
--- FAIL: TestCalculatePrune (0.00s)
txn_writer_test.go:602: calculated prune paths are not as expected.
(WNT) [/private/var/folders/hb/pdqmtgn954zbj319w8djtncr0000gn/T/gotest236842704/vendor/github.com/prune/pkg/sub /private/var/folders/hb/pdqmtgn954zbj319w8djtncr0000gn/T/gotest236842704/vendor/github.com/prune/pkg]
(GOT) [/private/var/folders/hb/pdqmtgn954zbj319w8djtncr0000gn/T/gotest236842704/vendor/github.com/prune/pkg/sub /private/var/folders/hb/pdqmtgn954zbj319w8djtncr0000gn/T/gotest236842704/vendor/github.com/prune/pkg /private/var/folders/hb/pdqmtgn954zbj319w8djtncr0000gn/T/gotest236842704/vendor/github.com/prune]
2383dce to
a2f09dc
Compare
|
AppVeyor is stuck again. 😞 |
dep.calculatePrune assumes "/" is the file separtor. This change fixes an issue caused by that on Windows. Fixes golang#775 Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho
force-pushed
the
fix-prune-bug-on-windows
branch
from
a2f09dc to
30ba901
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
As reported in #775 ,
dep prunedeletes all directories invendor. After digging in, the culpirt seems to becalculatePruneintxn_writer.go.This line assume all paths use
/as a separator. And therefore, causes this check to be alwaystrue(on filesystems that don't use/) thus adding all directories to thetoDeleteslice.What should your reviewer look out for in this PR?
Generic review.
Which issue(s) does this PR fix?
fixes #775