Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

dep prune is deleting the entire folder (on Windows only) #775

Closed
andreynering opened this issue Jun 20, 2017 · 4 comments · Fixed by #780
Closed

dep prune is deleting the entire folder (on Windows only) #775

andreynering opened this issue Jun 20, 2017 · 4 comments · Fixed by #780
Assignees
@ibrasho
Labels
bug

Comments

@andreynering
Copy link

What version of Go (go version) and dep (git describe --tags) are you using?

$ go version
go version go1.8 windows/386
$ git describe --tags
v0.1.0-175-gc79b048

Description

On Windows only, dep prune is deleting everything inside vendor leaving the folder empty. On Linux, it's working as intended.

I tried on two different projects. These are the files of one of them:
@ibrasho ibrasho mentioned this issue Jun 21, 2017
Merged
ibrasho added a commit to ibrasho-forks/dep that referenced this issue Jun 21, 2017
@ibrasho
dep: update calculatePrune to not assume "/" as separtor
0c1c8ea 
dep.calculatePrune assumes "/" is the file separtor. This change fixes
an issue caused by that on Windows.

Fixes golang#775

Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho added a commit to ibrasho-forks/dep that referenced this issue Jun 21, 2017
@ibrasho
dep: update calculatePrune to not assume "/" as separtor
07d30f6 
dep.calculatePrune assumes "/" is the file separtor. This change fixes
an issue caused by that on Windows.

Fixes golang#775

Signed-off-by: Ibrahim AshShohail <[email protected]>
@ibrasho ibrasho self-assigned this Jun 21, 2017
@ibrasho ibrasho added the bug label Jun 21, 2017
@ibrasho
Copy link
Collaborator

ibrasho commented Jun 21, 2017

@andreynering could you please try the PR and confirm if it solves the issue?

@andreynering
Copy link
Author

@ibrasho Sorry, it's not fixed yet. But the behavior changed a little.

Before I had an empty vendor:

vendor/

Now I have the next level of folder, but they're empty:

vendor/
  github.com/
  golang.org/
  gopkg.in/

@ibrasho
Copy link
Collaborator

ibrasho commented Jun 21, 2017 •
edited
Loading

What does dep prune -v output?

Edit: I've updated the PR after your comment. Please try it again if you have time.

ibrasho added a commit to ibrasho-forks/dep that referenced this issue Jun 21, 2017
@ibrasho
dep: update calculatePrune to not assume "/" as separtor
a9cd3d8 
dep.calculatePrune assumes "/" is the file separtor. This change fixes
an issue caused by that on Windows.

Fixes golang#775

Signed-off-by: Ibrahim AshShohail <[email protected]>
@andreynering
Copy link
Author

@ibrasho Seems to be fixed now. 😄

Log here if still needed.

ibrasho added a commit to ibrasho-forks/dep that referenced this issue Jun 21, 2017
@ibrasho
dep: update calculatePrune to not assume "/" as separtor
cfcd64e 
dep.calculatePrune assumes "/" is the file separtor. This change fixes
an issue caused by that on Windows.

Fixes golang#775

Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho added a commit to ibrasho-forks/dep that referenced this issue Jun 21, 2017
@ibrasho
dep: update calculatePrune to not assume "/" as separtor
05e9e87 
dep.calculatePrune assumes "/" is the file separtor. This change fixes
an issue caused by that on Windows.

Fixes golang#775

Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho added a commit to ibrasho-forks/dep that referenced this issue Jun 21, 2017
@ibrasho
dep: update calculatePrune to not assume "/" as separtor
0016724 
dep.calculatePrune assumes "/" is the file separtor. This change fixes
an issue caused by that on Windows.

Fixes golang#775

Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho added a commit to ibrasho-forks/dep that referenced this issue Jun 22, 2017
@ibrasho
dep: update calculatePrune to not assume "/" as separtor
70a3c5e 
dep.calculatePrune assumes "/" is the file separtor. This change fixes
an issue caused by that on Windows.

Fixes golang#775

Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho added a commit to ibrasho-forks/dep that referenced this issue Jun 22, 2017
@ibrasho
dep: update calculatePrune to not assume "/" as separtor
2383dce 
dep.calculatePrune assumes "/" is the file separtor. This change fixes
an issue caused by that on Windows.

Fixes golang#775

Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho added a commit to ibrasho-forks/dep that referenced this issue Jun 22, 2017
@ibrasho
dep: update calculatePrune to not assume "/" as separtor
a2f09dc 
dep.calculatePrune assumes "/" is the file separtor. This change fixes
an issue caused by that on Windows.

Fixes golang#775

Signed-off-by: Ibrahim AshShohail <[email protected]>
ibrasho added a commit to ibrasho-forks/dep that referenced this issue Jun 23, 2017
@ibrasho
dep: update calculatePrune to not assume "/" as separtor
30ba901 
dep.calculatePrune assumes "/" is the file separtor. This change fixes
an issue caused by that on Windows.

Fixes golang#775

Signed-off-by: Ibrahim AshShohail <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ibrasho ibrasho

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dep: update calculatePrune to not assume "/" as file separator ibrasho-forks/dep
2 participants
@ibrasho @andreynering