Add WeightedPages.Page

[bep]

I haven't wanted to do this because I didn't know how to without breaking lots of templates in the wild. But while cleaning up some other stuff, I think I found a way.

So taking one example from the docs:

<ul>
    {{ $type := .Type }}
    {{ range $key, $value := .Data.Terms.Alphabetical }}
        {{ $name := .Name }}
        {{ $count := .Count }}
        {{ with $.Site.GetPage (printf "/%s/%s" $type $name) }}
            <li><a href="{{ .Permalink }}">{{ $name }}</a> {{ $count }}</li>
        {{ end }}
    {{ end }}
</ul>

We should be able to rewrite this as:

<ul>
    {{ range .Data.Terms.Alphabetical }}
            <li><a href="{{ .Page.Permalink }}">{{ .Page.Title }}</a> {{ .Count }}</li>
    {{ end }}
</ul>

Note that I have replaced .Name with .Title in the example, because that is probably what you want in most cases. I have removed the preserveTaxonomyNames flag -- this will possibly be slightly breaking for some, but the logic was too hard to maintain -- and you can now use.Title which will preserve what you write in front matter.

/cc @regisphilibert

[regisphilibert]

This is great!

But while cleaning up some other stuff, I think I found a way.

Could this finding by any chance allow this improvement to be applied to the .Site.Taxonomy object as in:

<ul>
    {{ range .Site.Taxonomies.tags }}
            <li><a href="{{ .Page.Permalink }}">{{ .Page.Title }}</a> {{ .Count }}</li>
    {{ end }}
</ul>

[bep]

Could this finding by any chance allow this improvement to be applied to the .Site.Taxonomy object as in:

@regisphilibert yes. I just added a test for both the above constructs:

https://github.com/bep/hugo/blob/cdcc7de233ef74a386d54d766d18c6b84e078043/hugolib/taxonomy_test.go#L284

So, the loops gets nicer, but look at the titles!

[regisphilibert]

Awesome !

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.