Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil input in IsDescendant etc. #5461

Closed
bep opened this issue Nov 23, 2018 · 1 comment
Closed

Handle nil input in IsDescendant etc. #5461

bep opened this issue Nov 23, 2018 · 1 comment
Assignees
Milestone

Comments

@bep
Copy link
Member

bep commented Nov 23, 2018

No description provided.

@bep bep added this to the v0.52 milestone Nov 23, 2018
@bep bep self-assigned this Nov 23, 2018
bep pushed a commit to bep/website-2 that referenced this issue Nov 23, 2018
This commit also bumps `netlify.toml` to a newer Hugo version, as variable overwrites needs Go 1.11. It can be made to work with older Hugo's, but ...

See gohugoio/hugo#5461
@bep bep closed this as completed in b09a403 Nov 28, 2018
sarahmaddox added a commit to sarahmaddox/website that referenced this issue Dec 23, 2018
commit 564d386
Merge: 1c9f27f 665219a
Author: Sarah Maddox <[email protected]>
Date:   Sun Dec 23 11:05:27 2018 +1100

    Merged updates from master.

commit 1c9f27f
Merge: 1df13a8 4f706ac
Author: Sarah Maddox <[email protected]>
Date:   Sat Dec 22 13:27:18 2018 +1100

    Merge branch 'master' of https://github.com/kubeflow/website into docsy

commit 1df13a8
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 15:46:42 2018 +1100

    Changed colour of 'info' style for down-arrow on home page.

commit e4acb8c
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 15:39:13 2018 +1100

    Updated footer for Docsy theme.

commit a2e6b77
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 14:34:31 2018 +1100

    Home page in progress: Added background image and more styling.

commit 360f49c
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 14:10:40 2018 +1100

    Work in progress: Rebuilding the home page in Docsy.

commit 8a3bd40
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 14:08:38 2018 +1100

    Work in progress: Rebuilding the home page in Docsy.

commit c882169
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 10:44:24 2018 +1100

    Removed unneeded CSS classes.

commit e123464
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 09:17:29 2018 +1100

    Didn't work. Reverting change.

commit 0027f17
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 09:14:54 2018 +1100

    Trying a quick fix to get Netlify to recognise updated styles.

commit 319441b
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 08:44:43 2018 +1100

    Fixed URL variable for version dropdown.

commit 5c38130
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 08:41:58 2018 +1100

    Got the version selector working in the navbar.

commit a517d9d
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 08:13:05 2018 +1100

    Removed the word 'default' from the custom CSS variable definitions.

commit 1e58973
Merge: e9018cd 97a7a38
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 17 06:32:36 2018 +1100

    Merging docsy branch with upstream master.

commit e9018cd
Author: Sarah Maddox <[email protected]>
Date:   Sun Dec 9 06:40:19 2018 -0800

    In progress: Adding the versions menu in the top nav.

commit 9dd7b77
Author: Sarah Maddox <[email protected]>
Date:   Sat Dec 8 15:05:33 2018 -0800

    Added Kubeflow colours to top nav.

commit be93b08
Author: Sarah Maddox <[email protected]>
Date:   Sat Dec 8 14:12:45 2018 -0800

    Forcing commit of resources.

commit f5ef213
Author: Sarah Maddox <[email protected]>
Date:   Sat Dec 8 14:04:01 2018 -0800

    Removed the kf theme.

commit 66af180
Author: Sarah Maddox <[email protected]>
Date:   Sat Dec 8 14:01:14 2018 -0800

    Minor fixes.

commit 1bafeaa
Author: Sarah Maddox <[email protected]>
Date:   Sat Dec 8 10:43:48 2018 -0800

    Minor clarification in config comment.

commit be3fbbc
Merge: b17e908 a574bd1
Author: Sarah Maddox <[email protected]>
Date:   Sat Dec 8 08:39:21 2018 -0800

    Merged and resolved conflicts from upstream/master.

commit b17e908
Author: Sarah Maddox <[email protected]>
Date:   Tue Dec 4 19:33:39 2018 +1300

    Add a .gitattributes file to ignore the resources files in diffs and merge conflicts.

commit 614aa20
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 16:57:17 2018 +1100

    Added the 'resources' directory to gitignore, as we don't want everyone updating it unless they mean to.

commit 6b7bbe8
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 16:50:32 2018 +1100

    Initial version of list pages for the docs.

commit 0a706e7
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 16:13:32 2018 +1100

    Moved top-level index page and 404 page out of kf theme into project.

commit 1c8adc8
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 16:00:03 2018 +1100

    Removed 'docs' menu config from config file.

commit 9920cb8
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 15:43:54 2018 +1100

    Adjusted page front matter for the 'Getting Started' section.

commit 2d7fdaf
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 15:38:45 2018 +1100

    Adjusted page front matter for rest of the 'Guides' section.

commit 413602f
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 15:17:20 2018 +1100

    Adjusted page front matter for the 'Components' section.

commit 2e4d142
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 13:53:42 2018 +1100

    Added the 'resources' directory after local 'extended' Hugo build.

commit 49aecfd
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 13:32:37 2018 +1100

    Updated the package-lock JSON file updated by npm.

commit 4ad5052
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 13:30:42 2018 +1100

    Added the package-lock JSON file needed by npm.

commit 39f2475
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 13:16:37 2018 +1100

    Removed resources and guild modifications that were supposed to fix Netlify build issue.

commit 3173901
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 12:08:53 2018 +1100

    Adjusts page front matter for the 'About' section.

commit 48d3926
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 11:43:37 2018 +1100

    Added pipelines index file for Docsy toc.

commit 46dc207
Merge: 1498cef 9d35949
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 11:13:17 2018 +1100

    Merge branch 'master' of https://github.com/kubeflow/website into docsy

commit 1498cef
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 11:11:38 2018 +1100

    Initial commit of index files to define Docsy toc.

commit 25b0437
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 09:37:36 2018 +1100

    Netfify build issue - adding dependencies.

commit a7cbf58
Merge: f79d75a ef74793
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 08:36:17 2018 +1100

    Merge branch 'docsy' of github.com:sarahmaddox/website into docsy

commit f79d75a
Author: Sarah Maddox <[email protected]>
Date:   Mon Dec 3 08:34:25 2018 +1100

    Still trying to fix the Netlify build problem.

commit ef74793
Author: Sarah Maddox <[email protected]>
Date:   Tue Nov 27 15:47:25 2018 +1100

    Check in JS resources as workaround to Netlify build issue kubeflow#182 (unable to build from Hugo extended version).

commit 595354b
Merge: c25388f d289d5b
Author: Sarah Maddox <[email protected]>
Date:   Sat Nov 24 05:47:28 2018 +1100

    Merge branch 'nil-fixes' of https://github.com/bep/website-2 into docsy

commit c25388f
Merge: d9412c1 7f27714
Author: Sarah Maddox <[email protected]>
Date:   Sat Nov 24 05:39:47 2018 +1100

    Pull updated config from GitHub after merging pull request on GitHub UI.

commit d9412c1
Merge: 72de12d aecdccb
Author: Sarah Maddox <[email protected]>
Date:   Sat Nov 24 05:31:18 2018 +1100

    Merge branch 'master' of https://github.com/kubeflow/website into docsy

commit 7f27714
Merge: 72de12d 810c071
Author: Sarah Maddox <[email protected]>
Date:   Sat Nov 24 05:18:17 2018 +1100

    Merge pull request #1 from LisaFC/patch-1

    Fix duplicated params definition

commit 810c071
Author: LisaFC <[email protected]>
Date:   Fri Nov 23 15:37:45 2018 +0000

    Fix duplicated params definition

commit d289d5b
Author: Sarah Maddox <[email protected]>
Date:   Sun Nov 18 06:24:04 2018 +1100

    Ad nil checks for menus and footer links

    This commit also bumps `netlify.toml` to a newer Hugo version, as variable overwrites needs Go 1.11. It can be made to work with older Hugo's, but ...

    See gohugoio/hugo#5461

commit 72de12d
Author: Sarah Maddox <[email protected]>
Date:   Sun Nov 18 06:24:04 2018 +1100

    Fixed order of TOML entries - tables must go last.

commit 2edc7d2
Author: Sarah Maddox <[email protected]>
Date:   Wed Nov 14 17:13:43 2018 +1100

    Updated theme config and shortcodes for Docsy theme.

commit 4f9501d
Author: Sarah Maddox <[email protected]>
Date:   Wed Nov 14 07:19:20 2018 +1100

    Moved Docsy to the themes directory.

commit 940a461
Author: Sarah Maddox <[email protected]>
Date:   Wed Nov 14 07:07:44 2018 +1100

    Initial commit of Docsy theme.
k8s-ci-robot pushed a commit to kubeflow/website that referenced this issue Jan 3, 2019
* Initial commit of Docsy theme.

* Moved Docsy to the themes directory.

* Updated theme config and shortcodes for Docsy theme.

* Fixed order of TOML entries - tables must go last.

* Ad nil checks for menus and footer links

This commit also bumps `netlify.toml` to a newer Hugo version, as variable overwrites needs Go 1.11. It can be made to work with older Hugo's, but ...

See gohugoio/hugo#5461

* Fix duplicated params definition

* Check in JS resources as workaround to Netlify build issue #182 (unable to build from Hugo extended version).

* Still trying to fix the Netlify build problem.

* Netfify build issue - adding dependencies.

* Initial commit of index files to define Docsy toc.

* Added pipelines index file for Docsy toc.

* Adjusts page front matter for the 'About' section.

* Removed resources and guild modifications that were supposed to fix Netlify build issue.

* Added the package-lock JSON file needed by npm.

* Updated the package-lock JSON file updated by npm.

* Added the 'resources' directory after local 'extended' Hugo build.

* Adjusted page front matter for the 'Components' section.

* Adjusted page front matter for rest of the 'Guides' section.

* Adjusted page front matter for the 'Getting Started' section.

* Removed 'docs' menu config from config file.

* Moved top-level index page and 404 page out of kf theme into project.

* Initial version of list pages for the docs.

* Added the 'resources' directory to gitignore, as we don't want everyone updating it unless they mean to.

* Add a .gitattributes file to ignore the resources files in diffs and merge conflicts.

* Minor clarification in config comment.

* Minor fixes.

* Removed the kf theme.

* Forcing commit of resources.

* Added Kubeflow colours to top nav.

* In progress: Adding the versions menu in the top nav.

* Removed the word 'default' from the custom CSS variable definitions.

* Got the version selector working in the navbar.

* Fixed URL variable for version dropdown.

* Trying a quick fix to get Netlify to recognise updated styles.

* Didn't work. Reverting change.

* Removed unneeded CSS classes.

* Work in progress: Rebuilding the home page in Docsy.

* Work in progress: Rebuilding the home page in Docsy.

* Home page in progress: Added background image and more styling.

* Updated footer for Docsy theme.

* Changed colour of 'info' style for down-arrow on home page.

* Fixed copyright statement to match change in master.

* Moved favicons to right place so browser picks them up.

* Regenerated resources files.

* Fixed the link for editing pages in GitHub.

* In progress: styling for landing page.

* Finished styling for landing page.

* Regenerated the resources files.

* Fixed down-link on landing page.

* Improved styling of logo.

* Fixed logo styling except for mobile.

* Fixed logo styling on mobile.

* Tweaking the logo styles.

* Adding the nav CSS.
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant