Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove migrate-patch #20619

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

kariya-mitsuru
Copy link
Contributor

Comprehensive Summary of your change

PR #18668 (commit bf7c82b) removed notary, but the source code of migrate-patch and some process in the Makefile for it remained, so remove them.

Issue being fixed

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

PR goharbor#18668 (commit bf7c82b) removed notary, but the source code of
migrate-patch and some process in the Makefile for it remained, so
remove them.

Signed-off-by: Mitsuru Kariya <[email protected]>
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.28%. Comparing base (c8c11b4) to head (64c94da).
Report is 254 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20619       +/-   ##
===========================================
+ Coverage   45.36%   66.28%   +20.91%     
===========================================
  Files         244     1045      +801     
  Lines       13333   114079   +100746     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75612    +69563     
- Misses       6983    34348    +27365     
- Partials      301     4119     +3818     
Flag Coverage Δ
unittests 66.28% <ø> (+20.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1286 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 79886df into goharbor:main Aug 9, 2024
18 of 19 checks passed
wy65701436 added a commit to wy65701436/harbor that referenced this pull request Aug 9, 2024
cherry pick goharbor#20619

Signed-off-by: wang yan <[email protected]>
wy65701436 added a commit to wy65701436/harbor that referenced this pull request Aug 9, 2024
cherry pick goharbor#20619

Signed-off-by: wang yan <[email protected]>
wy65701436 added a commit to wy65701436/harbor that referenced this pull request Aug 9, 2024
cherry pick goharbor#20619

Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 mentioned this pull request Aug 9, 2024
5 tasks
zyyw pushed a commit that referenced this pull request Aug 12, 2024
cherry pick #20619

Signed-off-by: wang yan <[email protected]>
kunal-511 pushed a commit to kunal-511/harbor_local that referenced this pull request Aug 22, 2024
PR goharbor#18668 (commit bf7c82b) removed notary, but the source code of
migrate-patch and some process in the Makefile for it remained, so
remove them.

Signed-off-by: Mitsuru Kariya <[email protected]>
Co-authored-by: Shengwen YU <[email protected]>
Co-authored-by: Wang Yan <[email protected]>
Signed-off-by: kunal-511 <[email protected]>
@kariya-mitsuru kariya-mitsuru deleted the remove-migrate-patch branch September 24, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants