Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump goharbor/harbor to latest release #3738

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Bump goharbor/harbor to latest release #3738

merged 2 commits into from
Oct 3, 2024

Conversation

eks-distro-pr-bot
Copy link
Contributor

This PR bumps goharbor/harbor to the latest Git revision.

Compare changes
Release notes

/hold
/area dependencies

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 7, 2024
@sp1999 sp1999 added the sig/curated-packages Issue or pull request related to EKS-A Curated Packages label Sep 7, 2024
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

1 similar comment
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-goharbor-harbor-main branch 2 times, most recently from a19ba0a to 1607778 Compare September 11, 2024 08:08
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

1 similar comment
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-goharbor-harbor-main branch 2 times, most recently from 7dd5e5f to e9af318 Compare September 13, 2024 08:07
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-goharbor-harbor-main branch 2 times, most recently from 6839aca to 314b52a Compare October 2, 2024 08:07
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

1 similar comment
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-pr-bot eks-distro-pr-bot force-pushed the update-goharbor-harbor-main branch 2 times, most recently from b0412ce to 5ada4fa Compare October 3, 2024 08:07
@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-pr-bot
Copy link
Contributor Author

This pull request is incomplete and requires manual intervention from a team member!

The following steps in the upgrade flow failed:

  • Checksums and attribution generation

@eks-distro-bot eks-distro-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2024
@eks-distro-bot eks-distro-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2024
@abhay-krishna
Copy link
Member

/ok-to-test

abhay-krishna
abhay-krishna reviewed Oct 3, 2024
View reviewed changes
projects/goharbor/harbor/Makefile
@@ -42,8 +42,8 @@ RELEASEVERSION=$(shell cat $(REPO)/VERSION)

IMAGE_NAMES?=harbor-db harbor-portal harbor-core harbor-log harbor-nginx harbor-jobservice harbor-registry harbor-registryctl harbor-redis harbor-exporter harbor-trivy

BINARY_TARGET_FILES=harbor-core harbor-jobservice harbor-registryctl harbor-migrate-patch harbor-migrate harbor-exporter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They removed the migrate-patch utility in version v2.11.1. So we can stop building it.

abhay-krishna
abhay-krishna reviewed Oct 3, 2024
View reviewed changes
projects/goharbor/harbor/patches/0002-Generate-swagger-models-and-restapis.patch
@@ -1,7 +1,7 @@
From ebb065537a2eefb67fd69fd74c451a85d5d22996 Mon Sep 17 00:00:00 2001
Copy link
Member

@abhay-krishna abhay-krishna Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code here was generated by running the upstream gen_apis Make target.

abhay-krishna
abhay-krishna reviewed Oct 3, 2024
View reviewed changes
projects/goharbor/harbor/Help.mk
@@ -12,17 +12,15 @@ checkout-repo: ## Checkout upstream tag based on value in GIT_TAG file
patch-repo: ## Patch upstream repo with patches in patches directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They removed the migrate-patch utility in version v2.11.1. So we can stop building it.

@sp1999
Copy link
Member

sp1999 commented Oct 3, 2024

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna
Copy link
Member

/unhold

@eks-distro-bot eks-distro-bot merged commit fdd9eed into aws:main Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhay-krishna abhay-krishna abhay-krishna left review comments

Assignees

@sp1999 sp1999

@jhaanvi5 jhaanvi5

Labels
approved area/dependencies lgtm ok-to-test sig/curated-packages Issue or pull request related to EKS-A Curated Packages size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eks-distro-pr-bot @eks-distro-bot @abhay-krishna @sp1999 @jhaanvi5