ci: use Go 1.10/1.11, test with -race #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's work on this one after we migrate, since we'll need to touch these files anyhow. |
|
Cycling the PR to try and trigger fresh PR runs. |
theckman
requested changes
Sep 15, 2018
There was a problem hiding this comment.
@adamdecaf when you have a moment can you take care of the theckman/go-flock reference in the appveyor.yml file and make it gofrs/flock?
adamdecaf
force-pushed
the
update-ci
branch
from
bceb29c
to
44dfe27
Compare
|
@theckman Done. I rebased off master also. |
theckman
approved these changes
Sep 26, 2018
theckman
added a commit
that referenced
this pull request
Sep 26, 2018
ci: use Go 1.10/1.11, test with -race Signed-off-by: Tim Heckman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when looking over this project for gofrs/help-requests#26