Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Donation of go-flock #26

Closed
theckman opened this issue Aug 31, 2018 · 8 comments
Closed

Donation of go-flock #26

theckman opened this issue Aug 31, 2018 · 8 comments
Assignees
Labels
actively engaged good candidate good candidate for adoption

Comments

@theckman
Copy link
Member

Where is the project currently hosted?

https://github.com/theckman/go-flock

What languages other than Go does the project utilize?

Pure Go, but does have some gnarly Windows system calls.

When was the project's last activity?

~19 days ago.

Does the project have a maintainer, or a maintainer looking for someone to take
over the project?

Yeah. I'm not actively looking, but with it being the most popular flock package (according to imports) it seems good to make sure to maintain it.

What active projects replicate the popular functionality of this project, if any?

There don't appear to be any direct competitors. Plenty of projects have implemented their own flock in subpackages.

What are some example projects that make use of this package?

https://github.com/theckman/cronner
https://github.com/stripe/veneur

Are there any outstanding critical bugs that result in the library being
totally unusable or insecure?

Nope, should be pretty stable.

Please provide a link to the project importers from https://godoc.org. Example: https://godoc.org/github.com/gofrs/uuid?importers

https://godoc.org/github.com/theckman/go-flock?importers

What else would you like to mention about the project?

@theckman
Copy link
Member Author

@gofrs/all Considering my biases, would someone be willing to handle the investigation of this project to see if it's a good fit for us?

@niaow niaow self-assigned this Aug 31, 2018
@niaow niaow added the needs investigation we need to investigate some things about this project label Aug 31, 2018
@niaow
Copy link
Member

niaow commented Aug 31, 2018

So: package is relatively straightforward, and imported by 22 packages. I don't think that this would be too much of a maintenance burden. Here are some things that would need to be done:

  1. finish/merge this PR: Add an explicit Close function flock#21
  2. review the API and make any possible fixes/simplifications
  3. release a v1 for SemVer stability guarantees.
  4. add go.mod
  5. some small potential optimizations

This package is simple and useful.

Also, this would provide many simple issues which could be good-first-issue.

@niaow niaow added actively engaged and removed needs investigation we need to investigate some things about this project labels Aug 31, 2018
@niaow
Copy link
Member

niaow commented Aug 31, 2018

Repo will be transferred soon. This will also help us see how viable a repo transfer is for gofrs projects.

@adamdecaf
Copy link
Member

+1 to adopting this project. The code is straightforward enough and self contained.

I updated CI settings a bit: gofrs/flock#23

Right now go-flock is the top result for Go "lock file" queries: https://github.com/search?q=language%3Ago+%22file+lock%22

Fun tidbit: This project was almost added to dep: golang/dep#1117

@theckman
Copy link
Member Author

theckman commented Sep 1, 2018

I'm on a short vacation this weekend, so it'll likely not happen until early next week (unless I get some spare alone time).

@theckman
Copy link
Member Author

Was hoping PR 21 would get updated so I could merge it before moving the project.

@theckman
Copy link
Member Author

Merged. Will migrate now.

@theckman theckman added the good candidate good candidate for adoption label Sep 15, 2018
@theckman
Copy link
Member Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
actively engaged good candidate good candidate for adoption
Projects
None yet
Development

No branches or pull requests

3 participants