Refactor JavaScript integration and improve code readability. #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I'm not into C++ so I did some try/error to fix the issues for the CI.
Update
.github/actions
:workflow_call
to reuse it for better maintenance (I going to open up an issue with my suggestions)linux
builds by removingwerror=yes
, which could be enabled again but Wno-error="cast-function-type" didn't work withSCONSFLAGS
removing/changing issues inside the ci:
This branch should be squashed 👍