Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 4.0 msvc ci #162

Closed
wants to merge 1 commit into from
Closed

fix: 4.0 msvc ci #162

wants to merge 1 commit into from

Conversation

jaune
Copy link
Contributor

@jaune jaune commented Aug 30, 2023 •
edited
Loading

@jaune jaune marked this pull request as ready for review August 30, 2023 13:26
@jaune
Copy link
Contributor Author

jaune commented Aug 30, 2023

@fire I can not run the CI.

@jaune jaune mentioned this pull request Aug 30, 2023
Merged
@fire
Copy link
Collaborator

fire commented Aug 30, 2023

I’ll need to keep approving the cicd. Let me know if you have problems.

@nmerget
Copy link
Collaborator

nmerget commented Sep 25, 2023

@fire I can not run the CI.

Based on the failed job you need to order the #include in editor_tools.h alphabetically

@nmerget nmerget mentioned this pull request Sep 26, 2023
Merged
@fire fire deleted the branch godotjs:gd4-rebase October 1, 2023 14:21
@fire fire closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaune @fire @nmerget