-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Script.get_global_name()
#80487
Conversation
Needs to be documented |
bd136af
to
cba89bd
Compare
cba89bd
to
74a45af
Compare
I don't mind this change, but there is a related bug in GDScript: class InnerClass:
pass
func _ready():
print((InnerClass as GDScript).get_global_name()) # InnerClass godot/modules/gdscript/gdscript.cpp Lines 256 to 258 in 7df3933
godot/modules/gdscript/gdscript_compiler.cpp Lines 2928 to 2930 in 7df3933
|
This seems to be fixed, since now |
Yes, it was fixed in #81079. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but maybe the docs could be extended.
Any movement on this? Is this a candidate for the next dev build or anything? |
74a45af
to
e7e35e8
Compare
Updated the docs and rebased on your behalf. |
Thanks! |
Closes godotengine/godot-proposals#7474