Properly handle theme changes in the Skeleton3DEditor #65053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
force-pushed
the
editor-bones-but-no-meat
branch
from
64f964c to
1839ec9
Compare
akien-mga
reviewed
Aug 30, 2022
|
|
||
| get_tree()->connect("node_removed", callable_mp(this, &Skeleton3DEditor::_node_removed), Object::CONNECT_ONESHOT); | ||
| } break; | ||
| case NOTIFICATION_READY: { |
There was a problem hiding this comment.
Nitpick, but we try to keep a separation like between cases for _notification switches, as these are often big/method-sized scopes.
There was a problem hiding this comment.
But this code already didn't follow that convention so let's not make it block a regression fix.
akien-mga
approved these changes
Aug 30, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65037. Pretty much described in my comment there.