Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skeleton bones have invalid icons #65037

Closed
nathanfranke opened this issue Aug 29, 2022 · 3 comments · Fixed by #65053
Closed

Skeleton bones have invalid icons #65037

nathanfranke opened this issue Aug 29, 2022 · 3 comments · Fixed by #65053
Labels
bug regression topic:editor
Milestone
4.0

Comments

@nathanfranke
Copy link
Contributor

Godot version

v4.0.alpha.custom_build [e60086f]

System information

Arch on 5.19.2-arch1-1

Issue description

image

Steps to reproduce

Open MRP, right click mesh, new inherited scene, click skeleton

Minimal reproduction project

Just copied this MRP from # 56458
BoneAABBWarnings.zip
@akien-mga akien-mga added this to the 4.0 milestone Aug 29, 2022
@akien-mga akien-mga moved this to To Assess in 4.x Priority Issues Aug 29, 2022
@akien-mga akien-mga moved this from To Assess to Todo in 4.x Priority Issues Aug 29, 2022
@TokageItLab
Copy link
Member

TokageItLab commented Aug 29, 2022 •
edited
Loading

Maybe related by #65044 or #63358?

@YuriSizov
Copy link
Contributor

Maybe related by #65044 or #63358?

Very unlikely.

@YuriSizov
Copy link
Contributor

YuriSizov commented Aug 29, 2022 •
edited
Loading

It's probably a regression from #62845. Skeleton3DEditor doesn't seem to have any code that would react on the editor theme changes. Instead it only updates itself on enter tree. And after #62845 we don't have the theme available on ENTER_TREE.

While this is technically a regression from #62845, the solution is to properly handle THEME_CHANGED notification, as does the rest of the editor.

Edit: I'll patch it soon, btw.

@YuriSizov YuriSizov mentioned this issue Aug 29, 2022
Merged
Repository owner moved this from Todo to Done in 4.x Priority Issues Aug 30, 2022
@Calinou Calinou mentioned this issue Aug 30, 2022
Closed
@bruvzg bruvzg mentioned this issue Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression topic:editor
Projects
4.x Priority Issues
Archived in project
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Properly handle theme changes in the Skeleton3DEditor YuriSizov/godot
5 participants
@Calinou @akien-mga @YuriSizov @nathanfranke @TokageItLab